bluetooth: Remove device before dispatching event

bluetooth: Remove device before dispatching event

Changes the order in which we removed the device and dispatched the
disconnected event. The previous order (dispatch -> remove), could result
in removing a device that was added by the event handler.

BUG=621022
Committed: https://crrev.com/efe33416c5109c9d155eb081a4894201519d902e
Cr-Commit-Position: refs/heads/master@{#400601}

[ortuno, 2016-06-17 20:32:59]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2016-06-17 20:33:00]

scheib: PTAL

[ortuno, 2016-06-17 20:34:10]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 20:34:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2072423002/1

[commit-bot: I haz the power, 2016-06-17 22:07:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 22:07:39]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Jeffrey Yasskin, 2016-06-18 05:00:13]

jyasskin@chromium.org changed reviewers:
+ jyasskin@chromium.org

[Jeffrey Yasskin, 2016-06-18 05:00:14]

lgtm

https://codereview.chromium.org/2072423002/diff/1/content/renderer/bluetooth/...
File content/renderer/bluetooth/web_bluetooth_impl.cc (right):

https://codereview.chromium.org/2072423002/diff/1/content/renderer/bluetooth/...
content/renderer/bluetooth/web_bluetooth_impl.cc:187: // to avoid deleting a
device dispatchGattServerDisconnected might have
s/deleting/removing/, s/added/re-connected/, and
s/dispatchGattServerDisconnected/the gattserverdisconnected event handler/, I
think.

[Jeffrey Yasskin, 2016-06-18 05:03:57]

https://codereview.chromium.org/2072423002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/bluetooth/gattserverdisconnected-event/reconnect-during-disconnected-event.html
(right):

https://codereview.chromium.org/2072423002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/bluetooth/gattserverdisconnected-event/reconnect-during-disconnected-event.html:37:
}, 'A device disconnecting while connected should fire the
gattserverdisconnected event.');
This isn't the right title for this test.

[ortuno, 2016-06-18 20:01:19]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2016-06-18 20:01:20]

Thanks!

https://codereview.chromium.org/2072423002/diff/1/content/renderer/bluetooth/...
File content/renderer/bluetooth/web_bluetooth_impl.cc (right):

https://codereview.chromium.org/2072423002/diff/1/content/renderer/bluetooth/...
content/renderer/bluetooth/web_bluetooth_impl.cc:187: // to avoid deleting a
device dispatchGattServerDisconnected might have
On 2016/06/18 at 05:00:14, jyasskin (OOO until July 11) wrote:
> s/deleting/removing/, s/added/re-connected/, and
s/dispatchGattServerDisconnected/the gattserverdisconnected event handler/, I
think.

Done.

https://codereview.chromium.org/2072423002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/bluetooth/gattserverdisconnected-event/reconnect-during-disconnected-event.html
(right):

https://codereview.chromium.org/2072423002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/bluetooth/gattserverdisconnected-event/reconnect-during-disconnected-event.html:37:
}, 'A device disconnecting while connected should fire the
gattserverdisconnected event.');
On 2016/06/18 at 05:03:56, jyasskin (OOO until July 11) wrote:
> This isn't the right title for this test.

Done.

[ortuno, 2016-06-18 20:01:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
jyasskin@chromium.org
Link to the patchset: https://codereview.chromium.org/2072423002/#ps40001
(title: "Moar fixes")

[commit-bot: I haz the power, 2016-06-18 20:01:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2072423002/40001

[commit-bot: I haz the power, 2016-06-18 21:23:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-18 21:25:16]

Description was changed from

==========
bluetooth: Remove device before dispatching event

Changes the order in which we removed the device and dispatched the
disconnected event. The previous order (dispatch -> remove), could result
in removing a device that was added by the event handler.

BUG=621022
==========

to

==========
bluetooth: Remove device before dispatching event

Changes the order in which we removed the device and dispatched the
disconnected event. The previous order (dispatch -> remove), could result
in removing a device that was added by the event handler.

BUG=621022

Committed: https://crrev.com/efe33416c5109c9d155eb081a4894201519d902e
Cr-Commit-Position: refs/heads/master@{#400601}
==========

[commit-bot: I haz the power, 2016-06-18 21:25:18]

Patchset 3 (id:??) landed as
https://crrev.com/efe33416c5109c9d155eb081a4894201519d902e
Cr-Commit-Position: refs/heads/master@{#400601}