Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2072393002: Update Crashpad to improve macOS 10.12 support (Closed)

Created:
4 years, 6 months ago by Mark Mentovai
Modified:
4 years, 6 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Crashpad to improve macOS 10.12 support Update Crashpad to 495a64fcdb7c979fe0f46eeaa1017087589d67cb 6fe7c5414e46 mac: Update cl_kernels workaround for 10.12 495a64fcdb7c mac: Don’t check file offset values in Mach-O images BUG=crashpad:118, crashpad:120 Committed: https://crrev.com/bb97b78d3751cb42cc8fa880a7c0777b72226955 Cr-Commit-Position: refs/heads/master@{#400979}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -24 lines) Patch
M third_party/crashpad/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/mach_o_image_segment_reader.cc View 3 chunks +2 lines, -23 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mark Mentovai
4 years, 6 months ago (2016-06-17 20:12:44 UTC) #2
Robert Sesek
lgtm
4 years, 6 months ago (2016-06-17 20:14:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072393002/1
4 years, 6 months ago (2016-06-21 13:02:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 13:42:07 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 13:44:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb97b78d3751cb42cc8fa880a7c0777b72226955
Cr-Commit-Position: refs/heads/master@{#400979}

Powered by Google App Engine
This is Rietveld 408576698