Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: content/browser/tracing/tracing_controller_impl.cc

Issue 2072383002: Trace revision and v8 version for IterationInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: dep Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/tracing/DEPS ('k') | content/public/common/content_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/tracing/tracing_controller_impl.cc
diff --git a/content/browser/tracing/tracing_controller_impl.cc b/content/browser/tracing/tracing_controller_impl.cc
index 8380c45c44cd2924301ebd3b7e34f803daf23480..792592b94a7549ff236490722797be2d3ca0c75e 100644
--- a/content/browser/tracing/tracing_controller_impl.cc
+++ b/content/browser/tracing/tracing_controller_impl.cc
@@ -17,6 +17,7 @@
#include "base/trace_event/trace_event.h"
#include "build/build_config.h"
#include "components/tracing/common/process_metrics_memory_dump_provider.h"
+#include "components/version_info/version_info.h"
#include "content/browser/tracing/file_tracing_provider_impl.h"
#include "content/browser/tracing/trace_message_filter.h"
#include "content/browser/tracing/tracing_ui.h"
@@ -114,6 +115,8 @@ std::unique_ptr<base::DictionaryValue> GenerateTracingMetadataDict() {
metadata_dict->SetString("network-type", GetNetworkTypeString());
metadata_dict->SetString("product-version", GetContentClient()->GetProduct());
+ metadata_dict->SetString("v8-version", GetContentClient()->GetV8Version());
+ metadata_dict->SetString("revision", version_info::GetLastChange());
clamy 2016/06/24 11:32:12 How does this work with non-Chrome embedders?
Primiano Tucci (use gerrit) 2016/06/24 12:39:43 version_info is not a chrome thingy. It's a compon
metadata_dict->SetString("user-agent", GetContentClient()->GetUserAgent());
// OS
« no previous file with comments | « content/browser/tracing/DEPS ('k') | content/public/common/content_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698