chrome/browser/tracing/chrome_tracing_delegate.cc - Issue 2072383002: Trace revision and v8 version for IterationInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tracing/chrome_tracing_delegate.cc

Issue 2072383002: Trace revision and v8 version for IterationInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add revision in ChromeTracingDelegate and AwTracingDelegate to keep version_info out of content Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/tracing/chrome_tracing_delegate.cc

diff --git a/chrome/browser/tracing/chrome_tracing_delegate.cc b/chrome/browser/tracing/chrome_tracing_delegate.cc

index bd30679443e98af21fa6702541b3ca8159ac656f..d5bc97ad926eeee2bf52c8845006718f4b0fedb2 100644

--- a/chrome/browser/tracing/chrome_tracing_delegate.cc

+++ b/chrome/browser/tracing/chrome_tracing_delegate.cc

@@ -21,6 +21,7 @@

#include "components/prefs/pref_registry_simple.h"

#include "components/prefs/pref_service.h"

#include "components/variations/active_field_trials.h"

+#include "components/version_info/version_info.h"

#include "content/public/browser/background_tracing_config.h"

#include "content/public/browser/browser_thread.h"

@@ -167,6 +168,7 @@ void ChromeTracingDelegate::GenerateMetadataDict(

variations_list->AppendString(it);

metadata_dict->Set("field-trials", std::move(variations_list));

+ metadata_dict->SetString("revision", version_info::GetLastChange());

}

content::MetadataFilterPredicate