Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: android_webview/browser/tracing/aw_tracing_delegate.h

Issue 2072383002: Trace revision and v8 version for IterationInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add revision in ChromeTracingDelegate and AwTracingDelegate to keep version_info out of content Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef ANDROID_WEBVIEW_BROWSER_TRACING_AW_TRACING_DELEGATE_H_
6 #define ANDROID_WEBVIEW_BROWSER_TRACING_AW_TRACING_DELEGATE_H_
7
8 #include "content/public/browser/tracing_delegate.h"
9
10 namespace android_webview {
11
12 class AwTracingDelegate : public content::TracingDelegate {
13 public:
14 AwTracingDelegate();
15 ~AwTracingDelegate() override;
16
17 std::unique_ptr<content::TraceUploader> GetTraceUploader(
18 net::URLRequestContextGetter* request_context) override;
19
jam 2016/07/12 21:28:24 nit: per convention, put content::TracingDelegate
20 void GenerateMetadataDict(base::DictionaryValue* metadata_dict) override;
21
22 private:
jam 2016/07/12 21:28:24 nit: no need
23 };
24
25 } // namespace android_webview
26
27 #endif // ANDROID_WEBVIEW_BROWSER_TRACING_AW_TRACING_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698