Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2072373002: [Telemetry] Rename page_set to test_page_set to avoid naming conflict with page_sets module in gpu … (Closed)

Created:
4 years, 6 months ago by nednguyen
Modified:
4 years, 6 months ago
Reviewers:
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Rename page_set to test_page_set to avoid naming conflict with page_sets module in gpu test TBR=sullivan@chromium.org, kbr@chromium.org BUG=catapult:#2418 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/49a4f4ee864e47edcfb8a6efb378b462e9432a20

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -26 lines) Patch
D telemetry/telemetry/internal/testing/page_sets/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D telemetry/telemetry/internal/testing/page_sets/data/.gitignore View 1 chunk +0 lines, -1 line 0 comments Download
D telemetry/telemetry/internal/testing/page_sets/data/example_domain.json View 1 chunk +0 lines, -9 lines 0 comments Download
D telemetry/telemetry/internal/testing/page_sets/data/example_domain_001.wpr.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D telemetry/telemetry/internal/testing/page_sets/example_domain.py View 1 chunk +0 lines, -16 lines 0 comments Download
A + telemetry/telemetry/internal/testing/test_page_sets/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + telemetry/telemetry/internal/testing/test_page_sets/data/.gitignore View 0 chunks +-1 lines, --1 lines 0 comments Download
A + telemetry/telemetry/internal/testing/test_page_sets/data/example_domain.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + telemetry/telemetry/internal/testing/test_page_sets/data/example_domain_001.wpr.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + telemetry/telemetry/internal/testing/test_page_sets/example_domain.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M telemetry/telemetry/page/page_run_end_to_end_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/telemetry_unittest_deps.json View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072373002/1
4 years, 6 months ago (2016-06-17 20:05:07 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 20:26:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698