Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2072363002: Gerrit git cl upload: --squash is now default. (Closed)

Created:
4 years, 6 months ago by tandrii(chromium)
Modified:
4 years, 6 months ago
Reviewers:
Sergiy Byelozyorov
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@cl-squash
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Gerrit git cl upload: --squash is now default. You can override it for all devs of repo by adding line to codereview.settings: GERRIT_SQUASH_UPLOADS: (True|False) And even with that, individual devs can overide it for themselves with: git config [--global] --bool gerrit.override-squash-uploads (true|false) BUG=611892 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/a60502f2d3d74e70ffc77b2e54353a7dd0d31774

Patch Set 1 #

Patch Set 2 : refactor #

Patch Set 3 : add test for default #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -13 lines) Patch
M git_cl.py View 1 2 chunks +26 lines, -5 lines 0 comments Download
M tests/git_cl_test.py View 1 2 5 chunks +60 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072363002/1
4 years, 6 months ago (2016-06-17 19:39:49 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-17 19:43:02 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072363002/20001
4 years, 6 months ago (2016-06-17 19:55:12 UTC) #6
tandrii(chromium)
PTAL
4 years, 6 months ago (2016-06-17 19:58:20 UTC) #8
Sergiy Byelozyorov
lgtm
4 years, 6 months ago (2016-06-20 08:57:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072363002/40001
4 years, 6 months ago (2016-06-20 08:58:48 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 09:01:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/a60502f2d3d74e...

Powered by Google App Engine
This is Rietveld 408576698