Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: mojo/edk/system/data_pipe.h

Issue 2072353002: Give AwakableList's wake-up method the old state in addition to the new state. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/awakable_list_unittest.cc ('k') | mojo/edk/system/data_pipe.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/data_pipe.h
diff --git a/mojo/edk/system/data_pipe.h b/mojo/edk/system/data_pipe.h
index 3853efb50ea79eb5ce7599549f4bf31b270dc6e5..5afa4567309b8b7143d4f4d4f4b5a96b437cb3fb 100644
--- a/mojo/edk/system/data_pipe.h
+++ b/mojo/edk/system/data_pipe.h
@@ -275,11 +275,11 @@ class DataPipe final : public ChannelEndpointClient {
bool OnReadMessage(unsigned port, MessageInTransit* message) override;
void OnDetachFromChannel(unsigned port) override;
- void AwakeProducerAwakablesForStateChangeNoLock(
- const HandleSignalsState& new_producer_state)
+ void OnProducerMaybeStateChange(const HandleSignalsState& old_producer_state,
+ const HandleSignalsState& new_producer_state)
MOJO_EXCLUSIVE_LOCKS_REQUIRED(mutex_);
- void AwakeConsumerAwakablesForStateChangeNoLock(
- const HandleSignalsState& new_consumer_state)
+ void OnConsumerMaybeStateChange(const HandleSignalsState& old_consumer_state,
+ const HandleSignalsState& new_consumer_state)
MOJO_EXCLUSIVE_LOCKS_REQUIRED(mutex_);
void SetProducerClosed();
« no previous file with comments | « mojo/edk/system/awakable_list_unittest.cc ('k') | mojo/edk/system/data_pipe.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698