Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2072353002: Give AwakableList's wake-up method the old state in addition to the new state. (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Give AwakableList's wake-up method the old state in addition to the new state. * Also rename it from AwakeForStateChange() to OnStateChange(). * This is to prepare to make it possible to trigger on trailing edges in addition to leading edges (needed for wait sets, which watch state persistently). * Also clean up some of the data pipe wake-up code, possibly fixing some bugs (but at the very least making things more obviously correct). * (Some of the new code may be a bit slower than the old code, but ... it's also more obviously correct.) R=vardhan@google.com BUG=#350 Committed: https://chromium.googlesource.com/external/mojo/+/1b9cedff42bb9a2cf4ea82ac4d048ca50e67605a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -134 lines) Patch
M mojo/edk/system/awakable_list.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/awakable_list.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M mojo/edk/system/awakable_list_unittest.cc View 15 chunks +102 lines, -41 lines 0 comments Download
M mojo/edk/system/data_pipe.h View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/edk/system/data_pipe.cc View 11 chunks +50 lines, -64 lines 0 comments Download
M mojo/edk/system/local_message_pipe_endpoint.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M mojo/edk/system/mock_simple_dispatcher.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/edk/system/simple_dispatcher.h View 2 chunks +5 lines, -3 lines 0 comments Download
M mojo/edk/system/simple_dispatcher.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 6 months ago (2016-06-17 19:17:13 UTC) #1
vardhan
lgtm
4 years, 6 months ago (2016-06-17 20:19:23 UTC) #2
viettrungluu
4 years, 6 months ago (2016-06-17 20:38:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b9cedff42bb9a2cf4ea82ac4d048ca50e67605a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698