Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2072333002: Fix js error in VK on debug build (Closed)

Created:
4 years, 6 months ago by bshe
Modified:
4 years, 6 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix js error in VK on debug build The js error is because we forgot to add hotrodmode field in API's json file. This CL should fix it. BUG=620936 Committed: https://crrev.com/465d55d04e5751c27aef61408183a26ad7d3cf24 Cr-Commit-Position: refs/heads/master@{#400622}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M extensions/common/api/virtual_keyboard_private.json View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bshe
Hi Ken. Do you mind take a look at this small fix? Thanks
4 years, 6 months ago (2016-06-17 20:59:49 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 6 months ago (2016-06-17 21:00:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072333002/1
4 years, 6 months ago (2016-06-20 00:56:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 01:35:44 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 01:38:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/465d55d04e5751c27aef61408183a26ad7d3cf24
Cr-Commit-Position: refs/heads/master@{#400622}

Powered by Google App Engine
This is Rietveld 408576698