Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 207233003: Add "." accessors to GN. (Closed)

Created:
6 years, 9 months ago by brettw
Modified:
6 years, 9 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Add "." accessors to GN. Add support for values referring to a Scope, and add support for the dot operator to read such values out of a scope. This is not currently used for anything. A followup patch will use this for the template implementation. R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259608

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Error messages #

Patch Set 4 : iImprove comment #

Total comments: 2

Patch Set 5 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -31 lines) Patch
M tools/gn/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/gn.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/parse_tree.h View 1 2 chunks +37 lines, -6 lines 0 comments Download
M tools/gn/parse_tree.cc View 2 chunks +71 lines, -12 lines 0 comments Download
A tools/gn/parse_tree_unittest.cc View 1 1 chunk +49 lines, -0 lines 0 comments Download
M tools/gn/parser.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/parser.cc View 1 2 3 4 5 chunks +38 lines, -9 lines 0 comments Download
M tools/gn/parser_unittest.cc View 2 chunks +20 lines, -2 lines 0 comments Download
M tools/gn/scope.h View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
M tools/gn/scope.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M tools/gn/scope_unittest.cc View 1 chunk +54 lines, -0 lines 0 comments Download
M tools/gn/token.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/tokenizer.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M tools/gn/tokenizer_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M tools/gn/value.h View 5 chunks +16 lines, -1 line 0 comments Download
M tools/gn/value.cc View 9 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
This just adds support for using the . operator, but doesn't actually hook it up ...
6 years, 9 months ago (2014-03-24 16:58:27 UTC) #1
scottmg
LGTM https://codereview.chromium.org/207233003/diff/60001/tools/gn/parser.cc File tools/gn/parser.cc (right): https://codereview.chromium.org/207233003/diff/60001/tools/gn/parser.cc#newcode22 tools/gn/parser.cc:22: PRECEDENCE_ASSIGNMENT = 1, // Lowest prescedence. no 's' ...
6 years, 9 months ago (2014-03-25 05:04:22 UTC) #2
brettw
6 years, 9 months ago (2014-03-26 16:57:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 manually as r259608 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698