third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-freq-data.html - Issue 2072313002: Replace verbose option with brief option for Should().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-freq-data.html

Issue 2072313002: Replace verbose option with brief option for Should(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adjust message for default verbose output. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-downmix.html ('k') | third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-freq-data-smoothing.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-freq-data.html

diff --git a/third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-freq-data.html b/third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-freq-data.html

index acaf585b41d3c794b3d112bfb4425625f3c0db25..030c8d2dcbf9ece914735a00be67d761ccabdebc 100644

--- a/third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-freq-data.html

+++ b/third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-freq-data.html

@@ -184,9 +184,13 @@

var minValue = Math.min(...expected);

var maxValue = Math.max(...expected);

- basicTestsPassed = Should("Min FFT value", minValue)

+ basicTestsPassed = Should("Min FFT value", minValue, {

+ brief: true

+ })

.beLessThanOrEqualTo(analyser.minDecibels) && basicTestsPassed;

- basicTestsPassed = Should("Max FFT value", maxValue)

+ basicTestsPassed = Should("Max FFT value", maxValue, {

+ brief: true

+ })

.beGreaterThanOrEqualTo(analyser.maxDecibels) && basicTestsPassed;

// Test the byte frequency data.

@@ -198,9 +202,8 @@

var expectedByteData = convertFloatToByte(expected, analyser.minDecibels,

analyser.maxDecibels);

- basicTestsPassed = Should(analyser.fftSize + "-point byte FFT", byteFreqData, {

- verbose: true

- }).beCloseToArray(expectedByteData, 0) && basicTestsPassed;

+ basicTestsPassed = Should(analyser.fftSize + "-point byte FFT", byteFreqData)

+ .beCloseToArray(expectedByteData, 0) && basicTestsPassed;

}).then(context.resume.bind(context));