Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/iirfilter.html

Issue 2072313002: Replace verbose option with brief option for Should(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust message for default verbose output. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/iirfilter.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/iirfilter.html b/third_party/WebKit/LayoutTests/webaudio/iirfilter.html
index 5f1e42cb396d60036249c63a2d12f3ca2c925292..2488bce00d82778d956ddb18b9632e13a1784a92 100644
--- a/third_party/WebKit/LayoutTests/webaudio/iirfilter.html
+++ b/third_party/WebKit/LayoutTests/webaudio/iirfilter.html
@@ -166,7 +166,7 @@
// Threshold isn't exactly zero due to round-off in the single-precision IIRFilterNode
// computations versus the double-precision Javascript computations.
- Should('IIR 1-pole output', actual, {verbose: true})
+ Should('IIR 1-pole output', actual)
.beCloseToArray(expected, {relativeThreshold: 5.723e-8});
}).then(done);
});
@@ -224,13 +224,14 @@
// even if the threshold passes. Thus, only print out a very small number of elements
// of the array where we have tested that they are consistent.
Should("IIRFilter for Biquad " + filterType, actual, {
- precision: 5,
- verbose: true
+ precision: 5
})
.beCloseToArray(expected, errorThreshold);
var snr = 10*Math.log10(computeSNR(actual, expected));
- Should("SNR for IIRFIlter for Biquad " + filterType, snr).beGreaterThanOrEqualTo(snrThreshold);
+ Should("SNR for IIRFIlter for Biquad " + filterType, snr, {
+ brief: true
+ }).beGreaterThanOrEqualTo(snrThreshold);
}).then(done);
};
}
@@ -361,7 +362,9 @@
});
success = Should("Max difference between IIR and Biquad on channel " + channel,
- maxError).beLessThanOrEqualTo(errorThresholds[channel]);
+ maxError, {
+ brief: true
+ }).beLessThanOrEqualTo(errorThresholds[channel]);
}
if (success) {
@@ -547,7 +550,6 @@
Should("4-th order IIRFilter (biquad ref)",
actual, {
- verbose: true,
precision: 5
})
.beCloseToArray(expected, {
@@ -557,7 +559,9 @@
});
var snr = 10*Math.log10(computeSNR(actual, expected));
- Should("SNR of 4-th order IIRFilter (biquad ref)", snr)
+ Should("SNR of 4-th order IIRFilter (biquad ref)", snr, {
+ brief: true
+ })
.beGreaterThanOrEqualTo(108.947);
}).then(done);
});

Powered by Google App Engine
This is Rietveld 408576698