Fix pixel snapping issues when layers become composited

Source/core/rendering/RenderLayerCompositor.cpp

 /*
  * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 475 matching lines @@
     } else {
         ++m_secondaryCompositedLayerCount;
         m_secondaryBackingStoreBytes += backing->backingStoreMemoryEstimate();
     }
 
     String layerName;
 #ifndef NDEBUG
     layerName = layer->debugName();
 #endif
 
-    LOG(Compositing, "%*p %dx%d %.2fKB (%s) %s\n", 12 + depth * 2, layer, backing->compositedBounds().width(), backing->compositedBounds().height(),
+    LOG(Compositing, "%*p %dx%d %.2fKB (%s) %s\n", 12 + depth * 2, layer, backing->compositedBounds().width().round(), backing->compositedBounds().height().round(),

[eae, 2013/07/26 20:30:51]

Why not log the precise values?

[leviw_travelin_and_unemployed, 2013/07/26 20:36:21]

Good question :)

         backing->backingStoreMemoryEstimate() / 1024,
         logReasonsForCompositing(layer), layerName.utf8().data());
 }
 #endif
 
 void RenderLayerCompositor::addOutOfFlowPositionedLayer(RenderLayer* layer)
 {
     m_outOfFlowPositionedLayers.add(layer);
 }
 
@@ skipping 124 matching lines @@
 
         LayoutRect repaintRect = rect;
         repaintRect.moveBy(offset);
 
         compositedAncestor->setBackingNeedsRepaintInRect(repaintRect);
     }
 }
 
 // The bounds of the GraphicsLayer created for a compositing layer is the union of the bounds of all the descendant
 // RenderLayers that are rendered by the composited RenderLayer.
-IntRect RenderLayerCompositor::calculateCompositedBounds(const RenderLayer* layer, const RenderLayer* ancestorLayer) const
+LayoutRect RenderLayerCompositor::calculateCompositedBounds(const RenderLayer* layer, const RenderLayer* ancestorLayer) const
 {
     if (!canBeComposited(layer))
-        return IntRect();
+        return LayoutRect();
 
     RenderLayer::CalculateLayerBoundsFlags flags = RenderLayer::DefaultCalculateLayerBoundsFlags | RenderLayer::ExcludeHiddenDescendants | RenderLayer::DontConstrainForMask;
 #if HAVE(COMPOSITOR_FILTER_OUTSETS)
     // If the compositor computes its own filter outsets, don't include them in the composited bounds.
     if (!layer->paintsWithFilters())
         flags &= ~RenderLayer::IncludeLayerFilterOutsets;
 #endif
     return layer->calculateLayerBounds(ancestorLayer, 0, flags);
 }
 
@@ skipping 2060 matching lines @@
 
 Page* RenderLayerCompositor::page() const
 {
     if (Frame* frame = m_renderView->frameView()->frame())
         return frame->page();
 
     return 0;
 }
 
 } // namespace WebCore