Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 207223003: Make LayoutState members private (Closed)

Created:
6 years, 9 months ago by leviw_travelin_and_unemployed
Modified:
6 years, 9 months ago
CC:
blink-reviews, mstensho+blink_opera.com, chromiumbugtracker_adobe.com, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Make LayoutState members private Step 1 of refactoring LayoutState to be a more general quick-lookup while walking the tree. No behavior change, just better encapsulation. BUG=343896 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169759

Patch Set 1 : ToT #

Patch Set 2 : Fixing debug build issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -51 lines) Patch
M Source/core/rendering/LayoutState.h View 1 4 chunks +31 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderFlowThread.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderView.h View 1 7 chunks +7 lines, -14 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 1 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
leviw_travelin_and_unemployed
Easy one!
6 years, 9 months ago (2014-03-20 23:31:28 UTC) #1
ojan
lgtm
6 years, 9 months ago (2014-03-21 00:14:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/207223003/20001
6 years, 9 months ago (2014-03-21 00:14:53 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 00:16:40 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-21 00:16:41 UTC) #5
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 9 months ago (2014-03-21 00:22:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/207223003/20001
6 years, 9 months ago (2014-03-21 00:22:57 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 00:27:19 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-21 00:27:19 UTC) #9
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 9 months ago (2014-03-21 17:25:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/207223003/40001
6 years, 9 months ago (2014-03-21 17:25:23 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 18:22:35 UTC) #12
Message was sent while issue was closed. 
Change committed as 169759

Powered by Google App Engine
This is Rietveld 408576698