Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 2072173003: DevTools: fix front-end compilation problems after #399131 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
index 5a9a559350327578c64b3aa30b909c0195a65f5c..82710ee03e7cc28c6159b487f87dbb09ccdb1b5e 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
@@ -613,6 +613,14 @@ WebInspector.AggregatedTimelineTreeView.prototype = {
return true;
},
+ _createAggregator: function()
alph 2016/06/17 12:08:07 Annotate plz
+ {
+ return new WebInspector.TimelineAggregator(
+ event => WebInspector.TimelineUIUtils.eventStyle(event).title,
+ event => WebInspector.TimelineUIUtils.eventStyle(event).category.name
+ );
+ },
+
__proto__: WebInspector.TimelineTreeView.prototype,
};
@@ -636,8 +644,7 @@ WebInspector.CallTreeTimelineTreeView.prototype = {
_buildTree: function()
{
var topDown = this._buildTopDownTree(WebInspector.TimelineAggregator.eventId);
- var aggregator = new WebInspector.TimelineAggregator(event => WebInspector.TimelineUIUtils.eventStyle(event));
- return aggregator.performGrouping(topDown, this._groupBySetting.get());
+ return this._createAggregator().performGrouping(topDown, this._groupBySetting.get());
},
__proto__: WebInspector.AggregatedTimelineTreeView.prototype,
@@ -663,8 +670,7 @@ WebInspector.BottomUpTimelineTreeView.prototype = {
_buildTree: function()
{
var topDown = this._buildTopDownTree(WebInspector.TimelineAggregator.eventId);
- var aggregator = new WebInspector.TimelineAggregator(event => WebInspector.TimelineUIUtils.eventStyle(event));
- return WebInspector.TimelineProfileTree.buildBottomUp(topDown, aggregator.groupFunction(this._groupBySetting.get()));
+ return WebInspector.TimelineProfileTree.buildBottomUp(topDown, this._createAggregator().groupFunction(this._groupBySetting.get()));
},
__proto__: WebInspector.AggregatedTimelineTreeView.prototype

Powered by Google App Engine
This is Rietveld 408576698