Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2072173003: DevTools: fix front-end compilation problems after #399131 (Closed)

Created:
4 years, 6 months ago by caseq
Modified:
4 years, 6 months ago
Reviewers:
paulirish, alph
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix front-end compilation problems after #399131 BUG=614935 Committed: https://crrev.com/7c6861df88e8e16dd2be24270ab8836a6923e115 Cr-Commit-Position: refs/heads/master@{#400650}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js View 1 3 chunks +13 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
caseq
4 years, 6 months ago (2016-06-17 09:38:54 UTC) #2
alph
lgtm https://codereview.chromium.org/2072173003/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js (right): https://codereview.chromium.org/2072173003/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js#newcode616 third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js:616: _createAggregator: function() Annotate plz https://codereview.chromium.org/2072173003/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js (right): ...
4 years, 6 months ago (2016-06-17 12:08:07 UTC) #3
paulirish
lgtm appreciate you taking care of this.
4 years, 6 months ago (2016-06-17 12:38:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072173003/20001
4 years, 6 months ago (2016-06-17 13:09:41 UTC) #7
commit-bot: I haz the power
Failed to apply the patch.
4 years, 6 months ago (2016-06-17 14:21:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072173003/20001
4 years, 6 months ago (2016-06-20 09:35:40 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-20 11:12:19 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 11:14:09 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7c6861df88e8e16dd2be24270ab8836a6923e115
Cr-Commit-Position: refs/heads/master@{#400650}

Powered by Google App Engine
This is Rietveld 408576698