Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 2072093002: Remove style spans to follow the styles of list item (Closed)

Created:
2 years, 1 month ago by joone
Modified:
2 years ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove style spans to follow the styles of list item This CL removes style spans to follow the styles of list item when the text of the pasted or merged element becomes a list item. BUG=335955 TEST=editing/deleting/backspace-merge-into-list-item.html Committed: https://crrev.com/bb59e5b729913a2023ea70e50d0689626565dd7e Cr-Commit-Position: refs/heads/master@{#401533}

Patch Set 1 #

Patch Set 2 : fix test fails #

Total comments: 2

Patch Set 3 : fix the test case #

Patch Set 4 : rebaseline for fixing test fails #

Messages

Total messages: 15 (6 generated)
joone
yosin@ I tried to remove isLegacyAppleHTMLSpanElement() call from handleStyleSpansBeforeInsertion because of this CL. It's not ...
2 years ago (2016-06-22 03:07:22 UTC) #2
yosin_UTC9
lgtm w/ small nits in a test https://codereview.chromium.org/2072093002/diff/20001/third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-list-item.html File third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-list-item.html (right): https://codereview.chromium.org/2072093002/diff/20001/third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-list-item.html#newcode29 third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-list-item.html:29: document.execCommand('delete', null, ...
2 years ago (2016-06-22 03:53:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072093002/40001
2 years ago (2016-06-22 18:07:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/248452)
2 years ago (2016-06-22 19:22:55 UTC) #8
joone
Hi yosin@ Could you take a look at the latest CL for rebaseline? My CL ...
2 years ago (2016-06-23 00:16:39 UTC) #9
yosin_UTC9
still lgtm
2 years ago (2016-06-23 01:54:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072093002/60001
2 years ago (2016-06-23 02:30:54 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
2 years ago (2016-06-23 03:56:31 UTC) #13
commit-bot: I haz the power
2 years ago (2016-06-23 03:58:36 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/bb59e5b729913a2023ea70e50d0689626565dd7e
Cr-Commit-Position: refs/heads/master@{#401533}

Powered by Google App Engine
This is Rietveld 408576698