Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2072063002: Add c.sha1 as a dependency to the generator sources. (Closed)

Created:
4 years, 6 months ago by vardhan
Modified:
4 years, 6 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add c.sha1 as a dependency to the generator sources. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M mojo/public/tools/bindings/mojom.gni View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
vardhan
ptal
4 years, 6 months ago (2016-06-16 23:36:29 UTC) #2
azani
lgtm
4 years, 6 months ago (2016-06-16 23:36:53 UTC) #3
vardhan
4 years, 6 months ago (2016-06-16 23:38:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9a46a27c85f608681b8fdebcef67f976b976d23b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698