Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2072033003: Fix oes-texture-half-float.html on core profile GL. (Closed)

Created:
4 years, 6 months ago by Zhenyao Mo
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix oes-texture-half-float.html on core profile GL. BUG=620914 TEST=oes-texture-half-float.html with --enable-unsafe-es3-apis on Mac R=kbr@chromium.org Committed: https://crrev.com/00019cec462eb6c158c143fb555846946ce9db4f Cr-Commit-Position: refs/heads/master@{#400350}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix oes-texture-half-float.html on core profile GL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M ui/gl/gl_gl_api_implementation.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Zhenyao Mo
kbr: PTAL
4 years, 6 months ago (2016-06-17 00:51:07 UTC) #1
Ken Russell (switch to Gerrit)
lgtm https://codereview.chromium.org/2072033003/diff/1/ui/gl/gl_gl_api_implementation.cc File ui/gl/gl_gl_api_implementation.cc (right): https://codereview.chromium.org/2072033003/diff/1/ui/gl/gl_gl_api_implementation.cc#newcode167 ui/gl/gl_gl_api_implementation.cc:167: // LIMINANCE/ALPHA formats are emulated through RED and ...
4 years, 6 months ago (2016-06-17 00:52:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072033003/1
4 years, 6 months ago (2016-06-17 00:53:52 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/154371)
4 years, 6 months ago (2016-06-17 01:09:28 UTC) #6
Zhenyao Mo
https://codereview.chromium.org/2072033003/diff/1/ui/gl/gl_gl_api_implementation.cc File ui/gl/gl_gl_api_implementation.cc (right): https://codereview.chromium.org/2072033003/diff/1/ui/gl/gl_gl_api_implementation.cc#newcode167 ui/gl/gl_gl_api_implementation.cc:167: // LIMINANCE/ALPHA formats are emulated through RED and RG ...
4 years, 6 months ago (2016-06-17 02:48:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072033003/20001
4 years, 6 months ago (2016-06-17 02:48:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-17 03:52:31 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 03:54:46 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/00019cec462eb6c158c143fb555846946ce9db4f
Cr-Commit-Position: refs/heads/master@{#400350}

Powered by Google App Engine
This is Rietveld 408576698