ash/system/DEPS - Issue 2072023003: mash: Break ash system tray dependencies on ash::ShelfWidget

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/system/DEPS

Issue 2072023003: mash: Break ash system tray dependencies on ash::ShelfWidget (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 # jamescook@ is refactoring the system tray code to break dependencies on the
	msw 2016/06/17 19:58:37 optional nit: consider something like this one-lin optional nit: consider something like this one-liner: # NOTE: Use WmShelf for all external shelf access; see crbug.com/615502 James Cook 2016/06/17 20:14:32 Done. Show quoted text On 2016/06/17 19:58:37, msw wrote: > optional nit: consider something like this one-liner: > # NOTE: Use WmShelf for all external shelf access; see crbug.com/615502 Done.
	3 # internals of the shelf. Prefer //ash/common/shelf/wm_shelf.h instead.

	4 # http://crbug.com/615502

	5 "-ash/shelf/shelf_widget.h",

2 "-chromeos",	6 "-chromeos",

3 "+components/prefs",	7 "+components/prefs",

4 "+components/signin/core/account_id",	8 "+components/signin/core/account_id",

5 ]	9 ]

OLD	NEW

« no previous file with comments | « ash/shelf/shelf_widget.cc ('k') | ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc » ('j') | ash/system/tray/system_tray_unittest.cc » ('J')