mash: Move tray settings and deps to common.

mash: Move tray settings and deps to common.

tools/git/move_source_file.py ash/system/chromeos/devicetype_utils* ash/common/system/chromeos/
tools/git/move_source_file.py ash/system/chromeos/power/battery_notification* ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/dual_role_notification* ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/power_status* ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/tray_power* ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/settings/tray_settings* ash/common/system/chromeos/settings/
tools/git/move_source_file.py ash/system/system_notifier* ash/common/system/

Add ash_switches.h to allowed ash/common/DEPS; run "git cl format".
Convert tray_settings.cc ash::Shell uses to ash::WmShell.
Remove some unused shell[_delegate].h includes.

BUG=619636
TEST=compiles, ash_unittests
R=jamescook@chromium.org,sky@chromium.org
TBR=stevenjb@chromium.org

Committed: https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992
Cr-Commit-Position: refs/heads/master@{#400448}

[msw, 2016-06-16 22:07:36]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-16 22:08:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2072013002/1

[msw, 2016-06-16 22:16:41]

Description was changed from

==========
mash: Move tray settings and deps to common.

BUG=619636
TEST=compiles, ash_unittests
==========

to

==========
mash: Move tray settings and deps to common.

tools/git/move_source_file.py ash/system/chromeos/devicetype_utils*
ash/common/system/chromeos/
tools/git/move_source_file.py ash/system/chromeos/power/battery_notification*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/dual_role_notification*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/power_status*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/tray_power*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/settings/tray_settings*
ash/common/system/chromeos/settings/
tools/git/move_source_file.py ash/system/system_notifier* ash/common/system/

Add ash_switches.h to allowed ash/common/DEPS; run "git cl format".
Convert tray_settings.cc ash::Shell uses to ash::WmShell.
Remove some unused shell[_delegate].h includes.

BUG=619636
TEST=compiles, ash_unittests
R=jamescook@chromium.org
==========

[msw, 2016-06-16 22:16:41]

msw@chromium.org changed reviewers:
+ jamescook@chromium.org

[msw, 2016-06-16 22:31:08]

Hey James, please take a look; thanks!

[msw, 2016-06-16 22:54:04]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-16 22:55:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2072013002/20001

[James Cook, 2016-06-16 23:18:20]

LGTM.

https://codereview.chromium.org/2072013002/diff/20001/ash/common/DEPS
File ash/common/DEPS (right):

https://codereview.chromium.org/2072013002/diff/20001/ash/common/DEPS#newcode4
ash/common/DEPS:4: "+ash/ash_switches.h",
Not for this CL: One of us should do a CL that moves this. It's only referenced
in 90 places. :-)

[msw, 2016-06-16 23:24:48]

https://codereview.chromium.org/2072013002/diff/20001/ash/common/DEPS
File ash/common/DEPS (right):

https://codereview.chromium.org/2072013002/diff/20001/ash/common/DEPS#newcode4
ash/common/DEPS:4: "+ash/ash_switches.h",
On 2016/06/16 23:18:19, James Cook wrote:
> Not for this CL: One of us should do a CL that moves this. It's only
referenced
> in 90 places. :-)

Ack; I didn't realize we wanted to move (all?) ash/*.[h|cc] files.

[James Cook, 2016-06-16 23:28:34]

https://codereview.chromium.org/2072013002/diff/20001/ash/common/DEPS
File ash/common/DEPS (right):

https://codereview.chromium.org/2072013002/diff/20001/ash/common/DEPS#newcode4
ash/common/DEPS:4: "+ash/ash_switches.h",
On 2016/06/16 23:24:48, msw wrote:
> On 2016/06/16 23:18:19, James Cook wrote:
> > Not for this CL: One of us should do a CL that moves this. It's only
> referenced
> > in 90 places. :-)
> 
> Ack; I didn't realize we wanted to move (all?) ash/*.[h|cc] files.

Do you want to do that move, or shall I do it?

[msw, 2016-06-16 23:49:00]

https://codereview.chromium.org/2072013002/diff/20001/ash/common/DEPS
File ash/common/DEPS (right):

https://codereview.chromium.org/2072013002/diff/20001/ash/common/DEPS#newcode4
ash/common/DEPS:4: "+ash/ash_switches.h",
On 2016/06/16 23:28:33, James Cook wrote:
> On 2016/06/16 23:24:48, msw wrote:
> > On 2016/06/16 23:18:19, James Cook wrote:
> > > Not for this CL: One of us should do a CL that moves this. It's only
> > referenced
> > > in 90 places. :-)
> > 
> > Ack; I didn't realize we wanted to move (all?) ash/*.[h|cc] files.
> 
> Do you want to do that move, or shall I do it?

I'll do it.

[commit-bot: I haz the power, 2016-06-17 00:37:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 00:37:01]

Dry run: This issue passed the CQ dry run.

[msw, 2016-06-17 00:50:54]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-06-17 00:51:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2072013002/20001

[commit-bot: I haz the power, 2016-06-17 01:00:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 01:00:21]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[msw, 2016-06-17 01:48:59]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-06-17 01:49:00]

+Scott for c/b/OWNERS, ptal thanks!

[sky, 2016-06-17 15:02:23]

Rubber stamp LGTM

[msw, 2016-06-17 16:06:08]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-06-17 16:06:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2072013002/20001

[commit-bot: I haz the power, 2016-06-17 16:15:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 16:15:21]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[msw, 2016-06-17 17:14:33]

Description was changed from

==========
mash: Move tray settings and deps to common.

tools/git/move_source_file.py ash/system/chromeos/devicetype_utils*
ash/common/system/chromeos/
tools/git/move_source_file.py ash/system/chromeos/power/battery_notification*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/dual_role_notification*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/power_status*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/tray_power*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/settings/tray_settings*
ash/common/system/chromeos/settings/
tools/git/move_source_file.py ash/system/system_notifier* ash/common/system/

Add ash_switches.h to allowed ash/common/DEPS; run "git cl format".
Convert tray_settings.cc ash::Shell uses to ash::WmShell.
Remove some unused shell[_delegate].h includes.

BUG=619636
TEST=compiles, ash_unittests
R=jamescook@chromium.org
==========

to

==========
mash: Move tray settings and deps to common.

tools/git/move_source_file.py ash/system/chromeos/devicetype_utils*
ash/common/system/chromeos/
tools/git/move_source_file.py ash/system/chromeos/power/battery_notification*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/dual_role_notification*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/power_status*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/tray_power*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/settings/tray_settings*
ash/common/system/chromeos/settings/
tools/git/move_source_file.py ash/system/system_notifier* ash/common/system/

Add ash_switches.h to allowed ash/common/DEPS; run "git cl format".
Convert tray_settings.cc ash::Shell uses to ash::WmShell.
Remove some unused shell[_delegate].h includes.

BUG=619636
TEST=compiles, ash_unittests
R=jamescook@chromium.org,sky@chromium.org
TBR=stevenjb@chromium.org
==========

[msw, 2016-06-17 17:14:33]

msw@chromium.org changed reviewers:
+ stevenjb@chromium.org

[msw, 2016-06-17 17:15:22]

+TBR stevenjb for chrome/browser/ui/webui/options/OWNERS
(please take a look as you have time, just updating include paths)

[msw, 2016-06-17 17:15:35]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-06-17 17:15:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2072013002/20001

[commit-bot: I haz the power, 2016-06-17 17:21:50]

Description was changed from

==========
mash: Move tray settings and deps to common.

tools/git/move_source_file.py ash/system/chromeos/devicetype_utils*
ash/common/system/chromeos/
tools/git/move_source_file.py ash/system/chromeos/power/battery_notification*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/dual_role_notification*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/power_status*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/tray_power*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/settings/tray_settings*
ash/common/system/chromeos/settings/
tools/git/move_source_file.py ash/system/system_notifier* ash/common/system/

Add ash_switches.h to allowed ash/common/DEPS; run "git cl format".
Convert tray_settings.cc ash::Shell uses to ash::WmShell.
Remove some unused shell[_delegate].h includes.

BUG=619636
TEST=compiles, ash_unittests
R=jamescook@chromium.org,sky@chromium.org
TBR=stevenjb@chromium.org
==========

to

==========
mash: Move tray settings and deps to common.

tools/git/move_source_file.py ash/system/chromeos/devicetype_utils*
ash/common/system/chromeos/
tools/git/move_source_file.py ash/system/chromeos/power/battery_notification*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/dual_role_notification*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/power_status*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/tray_power*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/settings/tray_settings*
ash/common/system/chromeos/settings/
tools/git/move_source_file.py ash/system/system_notifier* ash/common/system/

Add ash_switches.h to allowed ash/common/DEPS; run "git cl format".
Convert tray_settings.cc ash::Shell uses to ash::WmShell.
Remove some unused shell[_delegate].h includes.

BUG=619636
TEST=compiles, ash_unittests
R=jamescook@chromium.org,sky@chromium.org
TBR=stevenjb@chromium.org
==========

[commit-bot: I haz the power, 2016-06-17 17:21:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-17 17:23:30]

Description was changed from

==========
mash: Move tray settings and deps to common.

tools/git/move_source_file.py ash/system/chromeos/devicetype_utils*
ash/common/system/chromeos/
tools/git/move_source_file.py ash/system/chromeos/power/battery_notification*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/dual_role_notification*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/power_status*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/tray_power*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/settings/tray_settings*
ash/common/system/chromeos/settings/
tools/git/move_source_file.py ash/system/system_notifier* ash/common/system/

Add ash_switches.h to allowed ash/common/DEPS; run "git cl format".
Convert tray_settings.cc ash::Shell uses to ash::WmShell.
Remove some unused shell[_delegate].h includes.

BUG=619636
TEST=compiles, ash_unittests
R=jamescook@chromium.org,sky@chromium.org
TBR=stevenjb@chromium.org
==========

to

==========
mash: Move tray settings and deps to common.

tools/git/move_source_file.py ash/system/chromeos/devicetype_utils*
ash/common/system/chromeos/
tools/git/move_source_file.py ash/system/chromeos/power/battery_notification*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/dual_role_notification*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/power_status*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/tray_power*
ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/settings/tray_settings*
ash/common/system/chromeos/settings/
tools/git/move_source_file.py ash/system/system_notifier* ash/common/system/

Add ash_switches.h to allowed ash/common/DEPS; run "git cl format".
Convert tray_settings.cc ash::Shell uses to ash::WmShell.
Remove some unused shell[_delegate].h includes.

BUG=619636
TEST=compiles, ash_unittests
R=jamescook@chromium.org,sky@chromium.org
TBR=stevenjb@chromium.org

Committed: https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992
Cr-Commit-Position: refs/heads/master@{#400448}
==========

[commit-bot: I haz the power, 2016-06-17 17:23:31]

Patchset 2 (id:??) landed as
https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992
Cr-Commit-Position: refs/heads/master@{#400448}

[DaleCurtis, 2016-06-17 19:16:10]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2016-06-17 19:16:11]

I think this broke SettingsFormatWebUITest.RadioCheckboxStyleCheck

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Test...

Will revert unless you think otherwise.

[msw, 2016-06-17 19:17:28]

On 2016/06/17 19:16:11, DaleCurtis wrote:
> I think this broke SettingsFormatWebUITest.RadioCheckboxStyleCheck
> 
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Test...
> 
> Will revert unless you think otherwise.

Looking... what bot is that? I haven't seen luci logs before.