Use loadHTMLString instead of data: and a mock WebURLLoader for loading html in RenderViewTest

Use loadHTMLString instead of data: and a mock WebURLLoader for loading html in RenderViewTest

BUG=

Committed: https://crrev.com/8f24c365532c86b5c27fb3dfc116091ef656f620
Cr-Commit-Position: refs/heads/master@{#400717}

[Nate Chapin, 2016-06-16 22:42:56]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-16 22:44:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2071983002/20001

[commit-bot: I haz the power, 2016-06-17 00:19:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 00:19:42]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2016-06-17 17:54:16]

japhet@chromium.org changed reviewers:
+ kinuko@chromium.org

[Nate Chapin, 2016-06-17 17:54:16]

kinuko, would you mind reviewing this quick cleanup CL?

There's a bunch of extra testing/mocking code in RenderViewTest to allow a data:
load with an overriden url. WebFrame::loadHTMLString() does that for us.

https://codereview.chromium.org/2071983002/diff/20001/content/public/test/ren...
File content/public/test/render_view_test.cc (left):

https://codereview.chromium.org/2071983002/diff/20001/content/public/test/ren...
content/public/test/render_view_test.cc:111: WebURLRequest
createDataRequest(const std::string& html) {
Inline this in its only remaining caller, LoadHTML()

[kinuko, 2016-06-20 04:58:28]

Wasn't super sure if the code before & after this change was doing the same
thing, but if we don't need that mock loader I'm totally cool with it :)

lgtm

https://codereview.chromium.org/2071983002/diff/20001/content/public/test/ren...
File content/public/test/render_view_test.cc (right):

https://codereview.chromium.org/2071983002/diff/20001/content/public/test/ren...
content/public/test/render_view_test.cc:185: std::string url_str =
"data:text/html;charset=utf-8,";
nit: let's not abbrev this, i.e. call it url_string ?

[Nate Chapin, 2016-06-20 16:54:01]

On 2016/06/20 04:58:28, kinuko wrote:
> Wasn't super sure if the code before & after this change was doing the same
> thing, but if we don't need that mock loader I'm totally cool with it :)

It's not absolutely identical, in that the old method emulates a data: url load
at the WebURLLoader level, while the new method uses a SubstituteData load
inside blink. But we provide WebFrame::loadHTMLString() for exactly this use
case.

> 
> lgtm
> 
>
https://codereview.chromium.org/2071983002/diff/20001/content/public/test/ren...
> File content/public/test/render_view_test.cc (right):
> 
>
https://codereview.chromium.org/2071983002/diff/20001/content/public/test/ren...
> content/public/test/render_view_test.cc:185: std::string url_str =
> "data:text/html;charset=utf-8,";
> nit: let's not abbrev this, i.e. call it url_string ?

[Nate Chapin, 2016-06-20 17:02:51]

https://codereview.chromium.org/2071983002/diff/20001/content/public/test/ren...
File content/public/test/render_view_test.cc (right):

https://codereview.chromium.org/2071983002/diff/20001/content/public/test/ren...
content/public/test/render_view_test.cc:185: std::string url_str =
"data:text/html;charset=utf-8,";
On 2016/06/20 04:58:28, kinuko wrote:
> nit: let's not abbrev this, i.e. call it url_string ?

Done.

[Nate Chapin, 2016-06-20 17:02:55]

The CQ bit was checked by japhet@chromium.org

[Nate Chapin, 2016-06-20 17:02:55]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/2071983002/#ps40001
(title: "url_str->url_string")

[commit-bot: I haz the power, 2016-06-20 17:04:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2071983002/40001

[commit-bot: I haz the power, 2016-06-20 17:46:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-20 17:53:47]

Description was changed from

==========
Use loadHTMLString instead of data: and a mock WebURLLoader for loading html in
RenderViewTest

BUG=
==========

to

==========
Use loadHTMLString instead of data: and a mock WebURLLoader for loading html in
RenderViewTest

BUG=

Committed: https://crrev.com/8f24c365532c86b5c27fb3dfc116091ef656f620
Cr-Commit-Position: refs/heads/master@{#400717}
==========

[commit-bot: I haz the power, 2016-06-20 17:53:48]

Patchset 3 (id:??) landed as
https://crrev.com/8f24c365532c86b5c27fb3dfc116091ef656f620
Cr-Commit-Position: refs/heads/master@{#400717}