Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2071963002: Revert of Gerrit git cl: allow overriding GERRIT_SQUASH_UPLOADS in git config. (Closed)

Created:
4 years, 6 months ago by tandrii(chromium)
Modified:
4 years, 6 months ago
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Gerrit git cl: allow overriding GERRIT_SQUASH_UPLOADS in git config. (patchset #2 id:20001 of https://codereview.chromium.org/2070013002/ ) Reason for revert: I suspect this broke squash setting setup. Original issue's description: > Gerrit git cl: allow overriding GERRIT_SQUASH_UPLOADS in git config. > > Previously, if GERRIT_SQUASH_UPLOADS was found in codereview.settings, > a local repository value of gerrit.squash-uploads would be set. > > This CL changes that, so that gerrit.squash-uploads property is written > with GERRIT_SQUASH_UPLOADS value ONLY IF the property wasn't set before. > > This allows individual users to choose their own way with > git config [--global] -bool gerrit.squash-uploads (true|false) > > BUG=611892 > R=andybons@chromium.org,sergiyb@chromium.org > > Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/768ec9a75560b5e5903d86654d4c1ab2afe17361 TBR=andybons@chromium.org,sergiyb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=611892 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/8dd81ea20b3830a816be88d73e61db2097716548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M git_cl.py View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
tandrii(chromium)
Created Revert of Gerrit git cl: allow overriding GERRIT_SQUASH_UPLOADS in git config.
4 years, 6 months ago (2016-06-16 20:24:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071963002/1
4 years, 6 months ago (2016-06-16 20:24:16 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 20:24:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/8dd81ea20b3830...

Powered by Google App Engine
This is Rietveld 408576698