Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2071953004: Revert of Remove redundant "layout size changed" state from LayoutSVGRoot (Closed)

Created:
4 years, 6 months ago by fs
Modified:
4 years, 6 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove redundant "layout size changed" state from LayoutSVGRoot (patchset #1 id:1 of https://codereview.chromium.org/2065093002/ ) Reason for revert: Possible cause of crbug.com/620228 Original issue's description: > Remove redundant "layout size changed" state from LayoutSVGRoot > > In LayoutSVGRoot::layout, two slightly different "layout size changed" > values are computed - one which is used for propagation to children > via SVGLayoutSupport::layoutSizeOfNearestViewportChanged > (|m_isLayoutSizeChanged|), and one which is used to mark direct > descendant children (local |layoutSizeChanged|). > Ultimately their use is the same though, so only using the more narrow > predicate for both of these cases should yield the same result. > It also has the side-effect of making it more obvious that changes to > layout-size is only of interest when there exist clients of the SVG > root that have relative lengths. > > BUG=603956 > > Committed: https://crrev.com/30770a70834c73670884f0de91bb7624df0ba003 > Cr-Commit-Position: refs/heads/master@{#399791} TBR=pdr@chromium.org,schenney@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=603956 Committed: https://crrev.com/7534b63d4979b824b1c3705d63a856028ff90fc5 Cr-Commit-Position: refs/heads/master@{#400411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
Created Revert of Remove redundant "layout size changed" state from LayoutSVGRoot
4 years, 6 months ago (2016-06-17 07:34:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071953004/1
4 years, 6 months ago (2016-06-17 07:34:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 10:09:04 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 10:11:48 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7534b63d4979b824b1c3705d63a856028ff90fc5
Cr-Commit-Position: refs/heads/master@{#400411}

Powered by Google App Engine
This is Rietveld 408576698