Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2071953002: Remove unused code. (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove unused code. This cl removes code that exists but is never called. This includes: * cfwl_formtp * cfwl_widgetdelegate * cfwl_scrollbar * cfwl_theme * cfwl_tooltip * PWL_Label * PWL_ListCtrl * PWL_Signature * PWL_IconList * BC_ResultPoint * BC_CommonPerspectiveTransform * BC_CommonBitSource * BC_PDF417Codeword * fx_codec_flate.h (the .cpp file still exists) Committed: https://pdfium.googlesource.com/pdfium/+/d931476503bc3ed2f0f6dda1ca2c18ef03bb1511

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3412 lines) Patch
M BUILD.gn View 7 chunks +0 lines, -27 lines 0 comments Download
M core/fxcodec/codec/fx_codec_flate.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D core/fxcodec/include/fx_codec_flate.h View 1 chunk +0 lines, -33 lines 0 comments Download
D fpdfsdk/pdfwindow/PWL_IconList.h View 1 chunk +0 lines, -115 lines 0 comments Download
D fpdfsdk/pdfwindow/PWL_IconList.cpp View 1 chunk +0 lines, -478 lines 0 comments Download
D fpdfsdk/pdfwindow/PWL_Label.h View 1 chunk +0 lines, -45 lines 0 comments Download
D fpdfsdk/pdfwindow/PWL_Label.cpp View 1 chunk +0 lines, -143 lines 0 comments Download
D fpdfsdk/pdfwindow/PWL_ListCtrl.h View 1 chunk +0 lines, -48 lines 0 comments Download
D fpdfsdk/pdfwindow/PWL_ListCtrl.cpp View 1 chunk +0 lines, -205 lines 0 comments Download
D fpdfsdk/pdfwindow/PWL_Signature.h View 1 chunk +0 lines, -67 lines 0 comments Download
D fpdfsdk/pdfwindow/PWL_Signature.cpp View 1 chunk +0 lines, -178 lines 0 comments Download
M pdfium.gyp View 2 chunks +0 lines, -9 lines 0 comments Download
M xfa.gyp View 1 5 chunks +0 lines, -18 lines 0 comments Download
D xfa/fwl/lightwidget/cfwl_scrollbar.h View 1 chunk +0 lines, -32 lines 0 comments Download
D xfa/fwl/lightwidget/cfwl_scrollbar.cpp View 1 chunk +0 lines, -108 lines 0 comments Download
D xfa/fwl/lightwidget/cfwl_theme.h View 1 chunk +0 lines, -60 lines 0 comments Download
D xfa/fwl/lightwidget/cfwl_theme.cpp View 1 chunk +0 lines, -140 lines 0 comments Download
D xfa/fwl/lightwidget/cfwl_tooltip.h View 1 chunk +0 lines, -60 lines 0 comments Download
D xfa/fwl/lightwidget/cfwl_tooltip.cpp View 1 chunk +0 lines, -125 lines 0 comments Download
D xfa/fwl/lightwidget/cfwl_widgetdelegate.h View 1 chunk +0 lines, -31 lines 0 comments Download
D xfa/fwl/lightwidget/cfwl_widgetdelegate.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
D xfa/fwl/theme/cfwl_formtp.h View 1 chunk +0 lines, -113 lines 0 comments Download
D xfa/fwl/theme/cfwl_formtp.cpp View 1 chunk +0 lines, -874 lines 0 comments Download
D xfa/fxbarcode/BC_ResultPoint.h View 1 chunk +0 lines, -25 lines 0 comments Download
D xfa/fxbarcode/BC_ResultPoint.cpp View 1 chunk +0 lines, -31 lines 0 comments Download
D xfa/fxbarcode/common/BC_CommonBitSource.h View 1 chunk +0 lines, -28 lines 0 comments Download
D xfa/fxbarcode/common/BC_CommonBitSource.cpp View 1 chunk +0 lines, -71 lines 0 comments Download
D xfa/fxbarcode/common/BC_CommonPerspectiveTransform.h View 1 chunk +0 lines, -66 lines 0 comments Download
D xfa/fxbarcode/common/BC_CommonPerspectiveTransform.cpp View 1 chunk +0 lines, -152 lines 0 comments Download
D xfa/fxbarcode/pdf417/BC_PDF417Codeword.h View 1 chunk +0 lines, -38 lines 0 comments Download
D xfa/fxbarcode/pdf417/BC_PDF417Codeword.cpp View 1 chunk +0 lines, -70 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dsinclair
PTAL.
4 years, 6 months ago (2016-06-16 20:24:28 UTC) #3
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-16 21:43:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071953002/20001
4 years, 6 months ago (2016-06-16 21:59:32 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 22:00:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/d931476503bc3ed2f0f6dda1ca2c18ef03bb...

Powered by Google App Engine
This is Rietveld 408576698