Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 207193002: [FastTextAutosizer] Remove comment about storing a fingerprint stack (Closed)

Created:
6 years, 9 months ago by pdr.
Modified:
6 years, 9 months ago
Reviewers:
skobes
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, rune+blink
Visibility:
Public.

Description

[FastTextAutosizer] Remove comment about storing a fingerprint stack This comment is no longer true (it may have never been either). The fingerprint logic is fairly cheap because we cache the parent hash. TBR=skobes NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M Source/core/rendering/FastTextAutosizer.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-20 23:20:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/207193002/1
6 years, 9 months ago (2014-03-20 23:20:12 UTC) #2
skobes
lgtm
6 years, 9 months ago (2014-03-20 23:21:21 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 23:21:42 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-20 23:21:43 UTC) #5
pdr.
On 2014/03/20 23:21:43, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 9 months ago (2014-03-20 23:23:24 UTC) #6
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-20 23:24:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/207193002/1
6 years, 9 months ago (2014-03-20 23:24:18 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 23:25:09 UTC) #9
Message was sent while issue was closed.
Change committed as 169708

Powered by Google App Engine
This is Rietveld 408576698