Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2071883002: S390: [wasm] Relocatable Globals. (Closed)

Created:
4 years, 6 months ago by john.yan
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [wasm] Relocatable Globals. Port 2d1f977c93942f58f0aaf886adb346f4eba5a1ea Original commit message: Support for relocatable globals, to facilitate compilation before instantiation. R=mtrofin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG=v8:5072 LOG=N Committed: https://crrev.com/b60da28cedb011e0e66468cfe18f24ef7c21dbe3 Cr-Commit-Position: refs/heads/master@{#37041}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M src/compiler/s390/code-generator-s390.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/s390/assembler-s390.cc View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
john.yan
PTAL
4 years, 6 months ago (2016-06-16 14:34:10 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071883002/1
4 years, 6 months ago (2016-06-16 14:34:36 UTC) #3
JaideepBajwa
lgtm
4 years, 6 months ago (2016-06-16 14:37:17 UTC) #4
Mircea Trofin
lgtm
4 years, 6 months ago (2016-06-16 14:48:27 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-16 14:58:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071883002/1
4 years, 6 months ago (2016-06-16 15:17:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 15:19:40 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 15:22:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b60da28cedb011e0e66468cfe18f24ef7c21dbe3
Cr-Commit-Position: refs/heads/master@{#37041}

Powered by Google App Engine
This is Rietveld 408576698