Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: chromeos/network/network_state.cc

Issue 207183003: Cleanup network event logging, add to ManagedNetworkConfigurationHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/network_configuration_handler.cc ('k') | chromeos/network/shill_property_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/network_state.cc
diff --git a/chromeos/network/network_state.cc b/chromeos/network/network_state.cc
index e6f344db80fc7ecae5536cc596e735d8eb0be789..eb598f0d750ba15955563998aa4420fccd68f7cf 100644
--- a/chromeos/network/network_state.cc
+++ b/chromeos/network/network_state.cc
@@ -158,7 +158,13 @@ bool NetworkState::PropertyChanged(const std::string& key,
bool NetworkState::InitialPropertiesReceived(
const base::DictionaryValue& properties) {
NET_LOG_DEBUG("InitialPropertiesReceived", path());
- bool changed = UpdateName(properties);
+ bool changed = false;
+ if (!properties.HasKey(shill::kTypeProperty)) {
+ NET_LOG_ERROR("NetworkState has no type",
+ shill_property_util::GetNetworkIdFromProperties(properties));
+ } else {
+ changed |= UpdateName(properties);
+ }
bool had_ca_cert_nss = has_ca_cert_nss_;
has_ca_cert_nss_ = IsCaCertNssSet(properties);
changed |= had_ca_cert_nss != has_ca_cert_nss_;
« no previous file with comments | « chromeos/network/network_configuration_handler.cc ('k') | chromeos/network/shill_property_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698