Cleanup network event logging, add to ManagedNetworkConfigurationHandler

chromeos/network/network_state.cc

Index: chromeos/network/network_state.cc
diff --git a/chromeos/network/network_state.cc b/chromeos/network/network_state.cc
index e6f344db80fc7ecae5536cc596e735d8eb0be789..eb598f0d750ba15955563998aa4420fccd68f7cf 100644
--- a/chromeos/network/network_state.cc
+++ b/chromeos/network/network_state.cc
@@ -158,7 +158,13 @@ bool NetworkState::PropertyChanged(const std::string& key,
 bool NetworkState::InitialPropertiesReceived(
     const base::DictionaryValue& properties) {
   NET_LOG_DEBUG("InitialPropertiesReceived", path());
-  bool changed = UpdateName(properties);
+  bool changed = false;
+  if (!properties.HasKey(shill::kTypeProperty)) {

[pneubeck (no reviews), 2014/03/21 09:33:42]

isn't in this case the NetworkState broken and will never be "repaired"?
can we ensure that such NetworkState is destructed/removed immediately? if not
and NetworkStateHandler still calls set_update_received(), we might even use
such incomplete states.

Alternatively, instead of checking (e.g. in GetNetworkState) for
update_received, we could use a new function
  bool NetworkState::IsValid() {
    return update_received() && !type_.empty();
  }

[stevenjb, 2014/03/21 17:08:51]

I put these checks in everywhere to track down the actual culprit, but yes, this
would be a major bug. It shouldn't ever happen, I don't think we need to add
special handling (certainly not in this CL), but if it ever did happen I thought
it would be better to log a specific error rather than get an error in
shill_property_util::GetNameFromProperties.

+    NET_LOG_ERROR("NetworkState has no type",
+                  shill_property_util::GetNetworkIdFromProperties(properties));
+  } else {
+    changed |= UpdateName(properties);
+  }
   bool had_ca_cert_nss = has_ca_cert_nss_;
   has_ca_cert_nss_ = IsCaCertNssSet(properties);
   changed |= had_ca_cert_nss != has_ca_cert_nss_;