Cleanup network event logging, add to ManagedNetworkConfigurationHandler

chromeos/network/network_configuration_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/network_configuration_handler.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 35 matching lines @@
   network_handler::RunErrorCallback(
       error_callback, service_path, error_name, error_msg);
 }
 
 void GetPropertiesCallback(
     const network_handler::DictionaryResultCallback& callback,
     const network_handler::ErrorCallback& error_callback,
     const std::string& service_path,
     DBusMethodCallStatus call_status,
     const base::DictionaryValue& properties) {
-  // Get the correct name from WifiHex if necessary.
   scoped_ptr<base::DictionaryValue> properties_copy(properties.DeepCopy());
-  std::string name =
-      shill_property_util::GetNameFromProperties(service_path, properties);
-  if (!name.empty()) {
-    properties_copy->SetStringWithoutPathExpansion(shill::kNameProperty, name);
+  if (properties.HasKey(shill::kTypeProperty)) {

[pneubeck (no reviews), 2014/03/21 09:33:42]

isn't this a major error and should stop the connection attempt / call
error_callback ?

if you keep it as it is, please drop a comment what this condition is for.

[stevenjb, 2014/03/21 17:08:51]

This one happens regularly, but it's because sometimes we request properties for
a service that is no longer there. I'll move the logic below the call_status
check instead.

+    // Get the correct name from WifiHex if necessary.
+    std::string name =
+        shill_property_util::GetNameFromProperties(service_path, properties);
+    if (!name.empty()) {
+      properties_copy->SetStringWithoutPathExpansion(
+          shill::kNameProperty, name);
+    }
   }
   if (call_status != DBUS_METHOD_CALL_SUCCESS) {
     // Because network services are added and removed frequently, we will see
     // failures regularly, so don't log these.
     network_handler::RunErrorCallback(error_callback,
                                       service_path,
                                       network_handler::kDBusFailedError,
                                       network_handler::kDBusFailedErrorMessage);
   } else if (!callback.is_null()) {
     callback.Run(service_path, *properties_copy.get());
@@ skipping 200 matching lines @@
 }
 
 void NetworkConfigurationHandler::CreateConfiguration(
     const base::DictionaryValue& properties,
     const network_handler::StringResultCallback& callback,
     const network_handler::ErrorCallback& error_callback) {
   ShillManagerClient* manager =
       DBusThreadManager::Get()->GetShillManagerClient();
   std::string type;
   properties.GetStringWithoutPathExpansion(shill::kTypeProperty, &type);
+  DCHECK(!type.empty());
   if (NetworkTypePattern::Ethernet().MatchesType(type)) {
     InvokeErrorCallback(
-        "" /* no service path */,
+        shill_property_util::GetNetworkIdFromProperties(properties),
         error_callback,
-        "ConfigureServiceForProfile is not implemented for Ethernet");
+        "ConfigureServiceForProfile: Invalid type: " + type);
     return;
   }
 
-  NET_LOG_USER("CreateConfiguration", type);
+  NET_LOG_USER("CreateConfiguration: " + type,
+               shill_property_util::GetNetworkIdFromProperties(properties));
   LogConfigProperties("Configure", type, properties);
 
   std::string profile;
   properties.GetStringWithoutPathExpansion(shill::kProfileProperty,
                                            &profile);
   DCHECK(!profile.empty());
   manager->ConfigureServiceForProfile(
       dbus::ObjectPath(profile),
       properties,
       base::Bind(&NetworkConfigurationHandler::RunCreateNetworkCallback,
@@ skipping 150 matching lines @@
 
 // static
 NetworkConfigurationHandler* NetworkConfigurationHandler::InitializeForTest(
     NetworkStateHandler* network_state_handler) {
   NetworkConfigurationHandler* handler = new NetworkConfigurationHandler();
   handler->Init(network_state_handler);
   return handler;
 }
 
 }  // namespace chromeos