Use data saver information to decide whether to preload.

Use data saver information to decide whether to preload.

This is done in addition of the connection type checking. We would
like to only use the data saver information going forward.

It's also fixing a bug where a <video autoplay> would always preload.

BUG=620755
Committed: https://crrev.com/8f23c95e8717937364735d634323c6cf9d707a7f
Cr-Commit-Position: refs/heads/master@{#401281}

[mlamouri (slow - plz ping), 2016-06-16 15:52:10]

mlamouri@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[mlamouri (slow - plz ping), 2016-06-16 15:52:14]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-16 15:52:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2071793003/1

[DaleCurtis, 2016-06-16 16:51:22]

lgtm, I like it. Two notes:
- If you want to roll in https://codereview.chromium.org/1528843004 that'd be
awesome. I haven't had time to finish that change out. Essentially limiting this
to http/https urls only.
- Should we change the default on android to preload=metadata? foolip@ has been
arguing for this forever.

[commit-bot: I haz the power, 2016-06-16 17:25:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 17:25:27]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2016-06-16 19:54:21]

On 2016/06/16 at 16:51:22, dalecurtis wrote:
> lgtm, I like it. Two notes:
> - If you want to roll in https://codereview.chromium.org/1528843004 that'd be
awesome. I haven't had time to finish that change out. Essentially limiting this
to http/https urls only.
> - Should we change the default on android to preload=metadata? foolip@ has
been arguing for this forever.

I want to ship this CL in the context of the autoplay changes we are doing in
M53. I don't think we need the two other changes in the same timeline. Both
changes look good though and I will make sure they are in the team backlog.

[DaleCurtis, 2016-06-17 17:49:11]

sgtm

[mlamouri (slow - plz ping), 2016-06-22 13:43:51]

Description was changed from

==========
Use data saver information to decide whether to preload.

It is more consistent with other decisions in HTMLMediaElement and
allows the embedder to be smarter about what data saver means instead
of doing basic connection type checking.

It's also fixing a bug where a <video autoplay> would always preload.

BUG=620755
==========

to

==========
Use data saver information to decide whether to preload.

This is done in addition of the connection type checking. We would
like to only use the data saver information going forward.

It's also fixing a bug where a <video autoplay> would always preload.

BUG=620755
==========

[mlamouri (slow - plz ping), 2016-06-22 13:44:37]

I did a small change here: it's checking for data saver *and* connection type. I
would like to start a discussion about preload policy changes which would drop
the connection type checks but I'm afraid doing this without larger consensus
might not bee seen positively.

[mlamouri (slow - plz ping), 2016-06-22 13:45:02]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-06-22 13:45:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2071793003/#ps20001
(title: "keep connection check")

[commit-bot: I haz the power, 2016-06-22 13:45:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2071793003/20001

[commit-bot: I haz the power, 2016-06-22 15:12:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-22 15:16:09]

Description was changed from

==========
Use data saver information to decide whether to preload.

This is done in addition of the connection type checking. We would
like to only use the data saver information going forward.

It's also fixing a bug where a <video autoplay> would always preload.

BUG=620755
==========

to

==========
Use data saver information to decide whether to preload.

This is done in addition of the connection type checking. We would
like to only use the data saver information going forward.

It's also fixing a bug where a <video autoplay> would always preload.

BUG=620755

Committed: https://crrev.com/8f23c95e8717937364735d634323c6cf9d707a7f
Cr-Commit-Position: refs/heads/master@{#401281}
==========

[commit-bot: I haz the power, 2016-06-22 15:16:11]

Patchset 2 (id:??) landed as
https://crrev.com/8f23c95e8717937364735d634323c6cf9d707a7f
Cr-Commit-Position: refs/heads/master@{#401281}