Issue 2071753002: Fix FLAG_code_comments crash for WASM functions

Issue 2071753002: Fix FLAG_code_comments crash for WASM functions (Closed)

Created:
4 years, 6 months ago by Jing

Modified:
4 years, 6 months ago

Reviewers:
Weiliang, titzer

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Fix FLAG_code_comments crash for WASM functions BUG= Committed: https://crrev.com/5c985733f96d0f27163643eac60494ff445e9ea0 Cr-Commit-Position: refs/heads/master@{#37078}

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/compiler/code-generator.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 8 (3 generated)

Jing

PTAL, it fixes --print-all-code or --code-comments crash when running WASM code

4 years, 6 months ago (2016-06-17 02:16:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071753002/1

4 years, 6 months ago (2016-06-19 06:26:06 UTC) #5

commit-bot: I haz the power

4 years, 6 months ago (2016-06-19 08:18:43 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5c985733f96d0f27163643eac60494ff445e9ea0
Cr-Commit-Position: refs/heads/master@{#37078}