Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: ui/gl/gl_image_ozone_native_pixmap_drm_unittest.cc

Issue 2071703002: Disable remaining tests that fail on the Linux desktop CrOS GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: only disable in ozone Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/ppapi/ppapi_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_image_ozone_native_pixmap_drm_unittest.cc
diff --git a/ui/gl/gl_image_ozone_native_pixmap_drm_unittest.cc b/ui/gl/gl_image_ozone_native_pixmap_drm_unittest.cc
index 273768274e30e0daceed649e0681f9eb0c1f6bd6..bd5aa3279d3a7c37b218586ae4f6b2d92c10b624 100644
--- a/ui/gl/gl_image_ozone_native_pixmap_drm_unittest.cc
+++ b/ui/gl/gl_image_ozone_native_pixmap_drm_unittest.cc
@@ -129,13 +129,17 @@ class GLImageOzoneNativePixmapDrmTestDelegate {
private:
};
-INSTANTIATE_TYPED_TEST_CASE_P(GLImageOzoneNativePixmapDrm,
- GLImageTest,
- GLImageOzoneNativePixmapDrmTestDelegate);
-INSTANTIATE_TYPED_TEST_CASE_P(GLImageOzoneNativePixmapDrm,
- GLImageBindTest,
- GLImageOzoneNativePixmapDrmTestDelegate);
+// TODO(crbug.com/618516) - The tests in this file can only be run
Daniele Castagna 2016/06/16 01:34:57 Do they build? If that's the case, can we just add
stevenjb 2016/06/16 16:42:11 They do build OK. I didn't think there was a way t
+// on a real device, and not on linux desktop builds, so they are
+// disabled until they can correctly detect the environment and do
+//INSTANTIATE_TYPED_TEST_CASE_P(GLImageOzoneNativePixmapDrm,
+// GLImageTest,
+// GLImageOzoneNativePixmapDrmTestDelegate);
+//
+//INSTANTIATE_TYPED_TEST_CASE_P(GLImageOzoneNativePixmapDrm,
+// GLImageBindTest,
+// GLImageOzoneNativePixmapDrmTestDelegate);
} // namespace
} // namespace gl
« no previous file with comments | « content/test/ppapi/ppapi_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698