Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2071683002: Make code compile with clang_use_chrome_plugin (part V) (Closed)

Created:
4 years, 6 months ago by Wei Li
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make code compile with clang_use_chrome_plugin (part V) This change mainly contains files in xfa/fxfa directory. This is part of the efforts to make PDFium code compilable by Clang chromium style plugins. The changes are mainly the following: -- move inline constructor/destructor of complex class/struct out-of-line; -- add constructor/destructor of complex class/struct if not explicitly defined; -- add explicit out-of-line copy constructor when needed; -- move inline virtual functions out-of-line; -- Properly mark virtual functions with 'override'; -- some minor cleanups; BUG=pdfium:469 Committed: https://pdfium.googlesource.com/pdfium/+/47bcd4c5c56cdc2d63a0c2ed4e7f68e6ccf523f6

Patch Set 1 #

Patch Set 2 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1009 lines, -614 lines) Patch
M xfa/fxfa/app/xfa_ffapp.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M xfa/fxfa/app/xfa_ffbarcode.h View 1 chunk +11 lines, -9 lines 0 comments Download
M xfa/fxfa/app/xfa_ffcheckbutton.h View 1 chunk +21 lines, -17 lines 0 comments Download
M xfa/fxfa/app/xfa_ffchoicelist.h View 1 2 chunks +56 lines, -50 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdraw.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffexclgroup.h View 1 chunk +6 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_fffield.h View 1 2 chunks +44 lines, -42 lines 0 comments Download
M xfa/fxfa/app/xfa_ffimage.h View 1 chunk +10 lines, -8 lines 0 comments Download
M xfa/fxfa/app/xfa_ffimageedit.h View 1 1 chunk +18 lines, -16 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpageview.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpath.h View 2 chunks +22 lines, -15 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpushbutton.h View 1 2 chunks +16 lines, -13 lines 0 comments Download
M xfa/fxfa/app/xfa_ffsignature.h View 1 chunk +25 lines, -24 lines 0 comments Download
M xfa/fxfa/app/xfa_ffsubform.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fftext.h View 1 1 chunk +14 lines, -12 lines 0 comments Download
M xfa/fxfa/app/xfa_fftextedit.h View 1 4 chunks +47 lines, -42 lines 0 comments Download
M xfa/fxfa/app/xfa_fftextedit.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 4 chunks +66 lines, -0 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidgetacc.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/app/xfa_fontmgr.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.h View 3 chunks +9 lines, -14 lines 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.cpp View 2 chunks +15 lines, -0 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.h View 1 11 chunks +35 lines, -106 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.cpp View 1 3 chunks +144 lines, -0 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_expression.h View 6 chunks +12 lines, -0 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_expression.cpp View 6 chunks +12 lines, -0 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.h View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fmparse.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fmparse.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_lexer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_lexer.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_simpleexpression.h View 7 chunks +10 lines, -5 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_simpleexpression.cpp View 7 chunks +14 lines, -0 lines 0 comments Download
M xfa/fxfa/include/fxfa.h View 5 chunks +10 lines, -30 lines 0 comments Download
M xfa/fxfa/include/xfa_ffapp.h View 1 chunk +5 lines, -4 lines 0 comments Download
M xfa/fxfa/include/xfa_ffpageview.h View 1 chunk +4 lines, -2 lines 0 comments Download
M xfa/fxfa/include/xfa_ffwidget.h View 1 5 chunks +37 lines, -36 lines 0 comments Download
M xfa/fxfa/include/xfa_fontmgr.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/include/xfa_rendercontext.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M xfa/fxfa/parser/cxfa_widgetdata.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_basic_imp.h View 1 chunk +28 lines, -36 lines 0 comments Download
M xfa/fxfa/parser/xfa_basic_imp.cpp View 2 chunks +30 lines, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_doclayout.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_layout_appadapter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_layout_itemlayout.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_layout_itemlayout.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_layout_pagemgr_new.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_locale.h View 2 chunks +55 lines, -48 lines 0 comments Download
M xfa/fxfa/parser/xfa_localemgr.h View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_object.h View 1 5 chunks +38 lines, -30 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 1 4 chunks +48 lines, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_parser_imp.h View 5 chunks +16 lines, -16 lines 0 comments Download
M xfa/fxfa/parser/xfa_parser_imp.cpp View 1 6 chunks +45 lines, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_script.h View 2 chunks +8 lines, -4 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_datawindow.h View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_eventpseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_layoutpseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_logpseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_resolveprocessor.h View 1 chunk +3 lines, -12 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_resolveprocessor.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_signaturepseudomodel.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Wei Li
pls review, thanks
4 years, 6 months ago (2016-06-16 03:33:09 UTC) #3
dsinclair
lgtm There are a few NULLs in there, but let's just do a pass later ...
4 years, 6 months ago (2016-06-16 14:59:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071683002/40001
4 years, 6 months ago (2016-06-16 14:59:36 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 15:00:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/47bcd4c5c56cdc2d63a0c2ed4e7f68e6ccf5...

Powered by Google App Engine
This is Rietveld 408576698