more uma stats

webkit/browser/appcache/appcache_histograms.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/browser/appcache/appcache_histograms.h"
 
 #include "base/metrics/histogram.h"
 
 namespace appcache {
 
@@ skipping 35 matching lines @@
   }
 }
 
 void AppCacheHistograms::CountCheckResponseResult(
     CheckResponseResultType result) {
   UMA_HISTOGRAM_ENUMERATION(
        "appcache.CheckResponseResult",
        result, NUM_CHECK_RESPONSE_RESULT_TYPES);
 }
 
+void AppCacheHistograms::CountResponseRetrieval(
+    bool success, bool is_main_resource, const GURL& origin_url) {
+  std::string label;
+  if (is_main_resource)
+    label = "appcache.MainResourceResponseRetrieval";
+  else
+    label = "appcache.SubResourceResponseRetrieval";
+  UMA_HISTOGRAM_BOOLEAN(label, success);

[Ilya Sherman, 2014/03/26 21:51:31]

This won't work.  The label needs to be a runtime constant in order to invoke
the UMA_HISTOGRAM_BOOLEAN macro.

[michaeln, 2014/03/26 22:58:53]

oops thank you, and the one below too

+  const std::string suffix = OriginToCustomHistogramSuffix(origin_url);
+  if (!suffix.empty()) {
+    base::BooleanHistogram::FactoryGet(
+        label + suffix,
+        base::HistogramBase::kUmaTargetedHistogramFlag)->Add(success);
+  }
+}
+
+void AppCacheHistograms::LogUpdateFailureStats(
+      const GURL& origin_url,
+      int percent_complete,
+      bool was_stalled,
+      bool was_off_origin_resource_failure) {
+  const std::string suffix = OriginToCustomHistogramSuffix(origin_url);
+
+  std::string label = "appcache.UpdateProgressAtPointOfFaliure";
+  UMA_HISTOGRAM_PERCENTAGE(label, percent_complete);
+  if (!suffix.empty()) {
+    base::LinearHistogram::FactoryGet(
+        label + suffix,
+        1, 101, 102,
+        base::HistogramBase::kUmaTargetedHistogramFlag)->Add(percent_complete);
+  }
+
+  label = "appcache.UpdateWasStalledAtPointOfFailure";

[jsbell, 2014/03/26 22:59:52]

Presumably this pattern will fail as well then? Bleah.

[Ilya Sherman, 2014/03/26 23:02:19]

That's fine -- label is a runtime constant here.  That is, at line 89, the label
is always guaranteed to be "appcache.UpdateWasStalledAtPointOfFailure".

+  UMA_HISTOGRAM_BOOLEAN(label, was_stalled);
+  if (!suffix.empty()) {
+    base::BooleanHistogram::FactoryGet(
+        label + suffix,
+        base::HistogramBase::kUmaTargetedHistogramFlag)->Add(was_stalled);
+  }
+
+  label = "appcache.UpdateWasOffOriginAtPointOfFailure";
+  UMA_HISTOGRAM_BOOLEAN(label, was_off_origin_resource_failure);
+  if (!suffix.empty()) {
+    base::BooleanHistogram::FactoryGet(
+        label + suffix,
+        base::HistogramBase::kUmaTargetedHistogramFlag)->Add(
+            was_off_origin_resource_failure);
+  }
+}
+
 void AppCacheHistograms::AddTaskQueueTimeSample(
     const base::TimeDelta& duration) {
   UMA_HISTOGRAM_TIMES("appcache.TaskQueueTime", duration);
 }
 
 void AppCacheHistograms::AddTaskRunTimeSample(
     const base::TimeDelta& duration) {
   UMA_HISTOGRAM_TIMES("appcache.TaskRunTime", duration);
 }
 
@@ skipping 27 matching lines @@
 }
 
 void AppCacheHistograms::AddMissingManifestDetectedAtCallsite(
     MissingManifestCallsiteType callsite) {
   UMA_HISTOGRAM_ENUMERATION(
        "appcache.MissingManifestDetectedAtCallsite",
        callsite, NUM_MISSING_MANIFEST_CALLSITE_TYPES);
 }
 
 }  // namespace appcache