tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 1a4329edb1d661ed76faed9b1b07bc372cd1ea67..e7cdd852b1ff80a6a451498ef7b96da880f375b0 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -331,6 +331,23 @@ other types of suffix sets.
   </summary>
 </histogram>
 
+<histogram name="appcache.MainResourceResponseRetrieval" enum="BooleanSuccess">
+  <owner>michaeln, jsbell</owner>

[Ilya Sherman, 2014/03/26 21:51:31]

Please write this as multiple <owner> lines, and use email addresses for the
owners.

[michaeln, 2014/03/26 23:47:21]

Done.

+  <summary>
+    Tracks the number of times a main resource is retreived from the appcache.
+    The boolean value indicates success or failure.

[Ilya Sherman, 2014/03/26 21:51:31]

This sentence is redundant with the enum labels.  Perhaps rephrase this as
something closer to "Tracks the success rate of retrieving a main resource from
the appcache"?

[michaeln, 2014/03/26 23:47:21]

Done.

+  </summary>
+</histogram>
+
+<histogram name="appcache.MainResourceResponseRetrieval.Docs"

[Ilya Sherman, 2014/03/26 21:51:31]

Please use a <fieldtrial> element at the bottom of this file rather than listing
every histogram twice.

[michaeln, 2014/03/26 22:58:53]

We've been listing per-domain histograms like this for a while.

How does the field trial stuff work? There's logic in the browser to log an
event to both labels. Would that logic need to change any? When viewing these
stats on uma.googleplex, do you need to look elsewhere to see the stats.

How is the field trial stuff better?

[Ilya Sherman, 2014/03/26 23:01:22]

It's purely a histograms.xml change that reduces repetition.  In this case,
you'd define

<fieldtrial name="appcacheSomethingOrOther" separator="">
  <group name="Docs" label="Only for docs.google.com"/>
  <affected-histogram name="..."/>
  <affected-histogram name="appcache.SubResourceResponseRetrieval"/>
  <affected-histogram name="..."/>
</fieldtrial>

and then not need to include all of the ".Docs" variants for the histograms.

[michaeln, 2014/03/26 23:47:21]

sgtm!

[michaeln, 2014/03/26 23:47:21]

Done.

+    enum="BooleanSuccess">
+  <owner>michaeln, jsbell</owner>
+  <summary>
+    Tracks the number of times a main resource is retreived from the appcache.
+    The boolean value indicates success or failure. Only for docs.google.com.
+  </summary>
+</histogram>
+
 <histogram name="appcache.MissingManifestDetectedAtCallsite"
     enum="AppCacheErrorSite">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
@@ -354,6 +371,23 @@ other types of suffix sets.
   </summary>
 </histogram>
 
+<histogram name="appcache.SubResourceResponseRetrieval" enum="BooleanSuccess">
+  <owner>michaeln, jsbell</owner>
+  <summary>
+    Tracks the number of times a sub resource is retreived from the appcache.
+    The boolean value indicates success or failure.
+  </summary>
+</histogram>
+
+<histogram name="appcache.SubResourceResponseRetrieval.Docs"
+    enum="BooleanSuccess">
+  <owner>michaeln, jsbell</owner>
+  <summary>
+    Tracks the number of times a sub resource is retreived from the appcache.
+    The boolean value indicates success or failure. Only for docs.google.com.
+  </summary>
+</histogram>
+
 <histogram name="appcache.TaskQueueTime" units="milliseconds">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <summary>
@@ -376,6 +410,53 @@ other types of suffix sets.
   <summary>AppCache update job result code, only for docs.google.com.</summary>
 </histogram>
 
+<histogram name="appcache.UpdateProgressAtPointOfFaliure" units="percent">
+  <owner>michaeln, jsbell</owner>
+  <summary>Percent completion at point of failure of an update job.</summary>
+</histogram>
+
+<histogram name="appcache.UpdateProgressAtPointOfFaliure.Docs" units="percent">
+  <owner>michaeln, jsbell</owner>
+  <summary>
+    Percent completion at point of failure of an update job. Only for
+    docs.google.com.
+  </summary>
+</histogram>
+
+<histogram name="appcache.UpdateWasOffOriginAtPointOfFailure"
+    units="BooleanSuccess">
+  <owner>michaeln, jsbell</owner>
+  <summary>
+    Whether the resource causing the failure was from a different origin.
+  </summary>
+</histogram>
+
+<histogram name="appcache.UpdateWasOffOriginAtPointOfFailure.Docs"
+    units="BooleanSuccess">
+  <owner>michaeln, jsbell</owner>
+  <summary>
+    Whether the resource causing the failure was from a different origin. Only
+    for docs.google.com.
+  </summary>
+</histogram>
+
+<histogram name="appcache.UpdateWasStalledAtPointOfFailure"
+    units="BooleanSuccess">

[Ilya Sherman, 2014/03/26 21:51:31]

Firstly, BooleanSuccess is an enum, not a unit.  Secondly, BooleanSuccess is not
an appropriate label for this histogram.  Please define a custom label.  Please
double-check the other histograms as well.

[michaeln, 2014/03/26 23:47:21]

Is there a semantically neutral bool enum defined? (poor bool, so burdened with
success). I'd really rather not add multiple new enum types and labels to this
monster file that are all variants of <TRUE, FALSE>.

(also, there's actually a good number of units="BooleanSuccess" misusages in
this file?)

[Ilya Sherman, 2014/03/27 00:02:45]

I think you're looking for the Boolean enum?

[michaeln, 2014/03/27 00:44:07]

indeed i am

+  <owner>michaeln, jsbell</owner>
+  <summary>
+    Whether any progresss had been made in the 5 minutes preceeding failure.
+  </summary>
+</histogram>
+
+<histogram name="appcache.UpdateWasStalledAtPointOfFailure.Docs"
+    units="BooleanSuccess">
+  <owner>michaeln, jsbell</owner>
+  <summary>
+    Whether any progresss had been made in the 5 minutes preceeding failure.
+    Only for docs.google.com.
+  </summary>
+</histogram>
+
 <histogram name="Apps.AppLaunch" enum="AppLaunch">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <summary>