Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2071623002: Revert of media: Enable media_mojo_unittests on bots (Closed)

Created:
4 years, 6 months ago by hcarmona
Modified:
4 years, 6 months ago
Reviewers:
jam, agable, xhwang, jam1, Nico
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of media: Enable media_mojo_unittests on bots (patchset #5 id:80001 of https://codereview.chromium.org/2053003002/ ) Reason for revert: Fails to compile on https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28dbg%29 Original issue's description: > media: Enable media_mojo_unittests on bots > > Also fix some BUILD.gn files. > > BUG=617204 > > Committed: https://crrev.com/72421f05b895615110d7fcc43b56e31942f34c54 > Cr-Commit-Position: refs/heads/master@{#399947} TBR=jam@chromium.org,agable@chromium.org,thakis@chromium.org,jam@google.com,xhwang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=617204 Committed: https://crrev.com/713cd6ebbed2081585792041aaf6cea5c704f699 Cr-Commit-Position: refs/heads/master@{#399978}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -20 lines) Patch
M BUILD.gn View 2 chunks +3 lines, -4 lines 0 comments Download
M media/mojo/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 2 chunks +0 lines, -12 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hcarmona
Created Revert of media: Enable media_mojo_unittests on bots
4 years, 6 months ago (2016-06-15 18:52:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071623002/1
4 years, 6 months ago (2016-06-15 18:52:45 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 18:53:57 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 18:55:19 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/713cd6ebbed2081585792041aaf6cea5c704f699
Cr-Commit-Position: refs/heads/master@{#399978}

Powered by Google App Engine
This is Rietveld 408576698