Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2071613002: Revert of GPU Watchdog to check I/O before terminating GPU process (Closed)

Created:
4 years, 6 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of GPU Watchdog to check I/O before terminating GPU process (patchset #5 id:120001 of https://codereview.chromium.org/1980263002/ ) Reason for revert: This CL seems to have caused intermittent assertion failures in the context_lost_tests on the commit queue and reliable assertion failures on some of the GPU bots. See http://crbug.com/619196 . Original issue's description: > GPU Watchdog to check I/O before terminating > > The idea is to try to do an unbuffered write in GPU watchdog > just before crashing the process. If the process is slow due > to heavy I/O this should give it more time to unblock. > > This should theoretically help with some of GPU hangs. > > BUG=612607 > > Committed: https://crrev.com/4015b488f743a7399e3362fd49917f494ff7caaf > Cr-Commit-Position: refs/heads/master@{#399222} TBR=jbauman@chromium.org,wfh@chromium.org,nick@chromium.org,manzagop@chromium.org,pmonette@chromium.org,brucedawson@chromium.org,stanisc@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=612607 Committed: https://crrev.com/40684e97fcc0cc24a2504f0dc2679a3b88557d9b Cr-Commit-Position: refs/heads/master@{#399998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -128 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 3 chunks +0 lines, -13 lines 0 comments Download
D content/common/gpu_watchdog_utils.h View 1 chunk +0 lines, -22 lines 0 comments Download
D content/common/gpu_watchdog_utils.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/gpu/gpu_watchdog_thread.h View 3 chunks +0 lines, -10 lines 0 comments Download
M content/gpu/gpu_watchdog_thread.cc View 6 chunks +11 lines, -59 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Ken Russell (switch to Gerrit)
Created Revert of GPU Watchdog to check I/O before terminating GPU process
4 years, 6 months ago (2016-06-15 18:34:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071613002/1
4 years, 6 months ago (2016-06-15 18:34:41 UTC) #3
Will Harris
were you able to gather any data from canary before the revert?
4 years, 6 months ago (2016-06-15 19:29:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 20:18:42 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/40684e97fcc0cc24a2504f0dc2679a3b88557d9b Cr-Commit-Position: refs/heads/master@{#399998}
4 years, 6 months ago (2016-06-15 20:21:05 UTC) #8
brucedawson
On 2016/06/15 19:29:04, Will Harris wrote: > were you able to gather any data from ...
4 years, 6 months ago (2016-06-16 00:26:10 UTC) #9
stanisc
4 years, 6 months ago (2016-06-16 00:46:09 UTC) #10
Message was sent while issue was closed.
On 2016/06/16 00:26:10, brucedawson wrote:
> On 2016/06/15 19:29:04, Will Harris wrote:
> > were you able to gather any data from canary before the revert?
> 
> Yes. In at least some cases there were long I/O delays in the hangs. stanisc@
> has the details and can share on the bug or elsewhere.

I'll update issue 612607.

Powered by Google App Engine
This is Rietveld 408576698