Allow constant static fields to overwrite defaults

Allow constant static fields to overwrite defaults

Now one can overwrite fields like 'name' as 'static const' fields in
their class definition and not get runtime errors.

BUG= https://github.com/dart-lang/dev_compiler/issues/587
R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/398132682375fb06e9e29d023bca3f95e1c68372

[stanm, 2016-06-15 20:26:17]

Description was changed from

==========
Allow constant static fields to overwrite defaults

Now one can overwrite fields like 'name' as 'static const' fields in
their class definition and not get runtime errors.

BUG=https://github.com/dart-lang/dev_compiler/issues/587
==========

to

==========
Allow constant static fields to overwrite defaults

Now one can overwrite fields like 'name' as 'static const' fields in
their class definition and not get runtime errors.

BUG=587
==========

[stanm, 2016-06-15 20:26:48]

Description was changed from

==========
Allow constant static fields to overwrite defaults

Now one can overwrite fields like 'name' as 'static const' fields in
their class definition and not get runtime errors.

BUG=587
==========

to

==========
Allow constant static fields to overwrite defaults

Now one can overwrite fields like 'name' as 'static const' fields in
their class definition and not get runtime errors.

BUG= https://github.com/dart-lang/dev_compiler/issues/587
==========

[Jennifer Messerly, 2016-06-15 20:28:53]

jmesserly@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2016-06-15 20:28:53]

https://codereview.chromium.org/2071593003/diff/1/lib/src/compiler/code_gener...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2071593003/diff/1/lib/src/compiler/code_gener...
lib/src/compiler/code_generator.dart:3408: !JS.invalidStaticFieldName(fieldName)
&&
So this check above was supposed to handle the invalid field name. Can we add
"name" to that?

[stanm, 2016-06-15 20:51:05]

https://codereview.chromium.org/2071593003/diff/1/lib/src/compiler/code_gener...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2071593003/diff/1/lib/src/compiler/code_gener...
lib/src/compiler/code_generator.dart:3408: !JS.invalidStaticFieldName(fieldName)
&&
On 2016/06/15 20:28:53, John Messerly wrote:
> So this check above was supposed to handle the invalid field name. Can we add
> "name" to that?

Done.

[stanm, 2016-06-15 20:51:40]

https://codereview.chromium.org/2071593003/diff/1/lib/src/compiler/code_gener...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2071593003/diff/1/lib/src/compiler/code_gener...
lib/src/compiler/code_generator.dart:3411:
js.statement('Object.defineProperty(#, #, { value: # });', [
Reverted in second patch set.

[Jennifer Messerly, 2016-06-15 20:57:52]

LGTM!

[stanm, 2016-06-15 21:03:40]

Description was changed from

==========
Allow constant static fields to overwrite defaults

Now one can overwrite fields like 'name' as 'static const' fields in
their class definition and not get runtime errors.

BUG= https://github.com/dart-lang/dev_compiler/issues/587
==========

to

==========
Allow constant static fields to overwrite defaults

Now one can overwrite fields like 'name' as 'static const' fields in
their class definition and not get runtime errors.

BUG= https://github.com/dart-lang/dev_compiler/issues/587
R=jmesserly@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/398132682375fb06e9e29d023bca...
==========

[stanm, 2016-06-15 21:03:41]

Committed patchset #3 (id:40001) manually as
398132682375fb06e9e29d023bca3f95e1c68372 (presubmit successful).