Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2071583004: Mark convert/streamed_conversion_json_utf8_decode_test as slow (Closed)

Created:
4 years, 6 months ago by Cutch
Modified:
4 years, 6 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : fschneider review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/lib/lib.status View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Cutch
4 years, 6 months ago (2016-06-16 18:14:16 UTC) #3
Florian Schneider
https://codereview.chromium.org/2071583004/diff/1/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/2071583004/diff/1/tests/lib/lib.status#newcode233 tests/lib/lib.status:233: convert/streamed_conversion_json_utf8_decode_test: Slow # Infrequent timeouts. Not sure why, but ...
4 years, 6 months ago (2016-06-16 18:16:18 UTC) #4
Florian Schneider
lgtm
4 years, 6 months ago (2016-06-16 18:16:28 UTC) #5
Cutch
https://codereview.chromium.org/2071583004/diff/1/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/2071583004/diff/1/tests/lib/lib.status#newcode233 tests/lib/lib.status:233: convert/streamed_conversion_json_utf8_decode_test: Slow # Infrequent timeouts. On 2016/06/16 18:16:17, Florian ...
4 years, 6 months ago (2016-06-16 18:17:44 UTC) #6
Cutch
4 years, 6 months ago (2016-06-16 18:18:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6d0c97114f74f3fdebf50dfd7eed9f80f8088dee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698