tools/gn/ninja_binary_target_writer.h - Issue 2071573003: GN: Use implicit dependency for binary input deps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_binary_target_writer.h

Issue 2071573003: GN: Use implicit dependency for binary input deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_binary_target_writer.h

diff --git a/tools/gn/ninja_binary_target_writer.h b/tools/gn/ninja_binary_target_writer.h

index 1876486ff1f9ab38ec58300835b87dcfeb091ce2..17db3841906e0c8dd0aa077c4321f1a4ea2cfc22 100644

--- a/tools/gn/ninja_binary_target_writer.h

+++ b/tools/gn/ninja_binary_target_writer.h

@@ -91,7 +91,6 @@ class NinjaBinaryTargetWriter : public NinjaTargetWriter {

// Writes a build line.

void WriteCompilerBuildLine(const SourceFile& source,

const std::vector<OutputFile>& extra_deps,

- const OutputFile& order_only_dep,

Toolchain::ToolType tool_type,

const std::vector<OutputFile>& outputs);