Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2071553002: Initial support of large mouse cursor on Exosphere (Closed)

Created:
4 years, 6 months ago by yoshiki
Modified:
4 years, 5 months ago
Reviewers:
reveman, sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initial support of large mouse cursor on Exosphere This patch adds support of large mouse cursor on Exosphere. If the large cursor set is selected, exosphere enlarges the cursor. BUG=b/29169901 TEST=Run unit_tests, and test manualy Committed: https://crrev.com/7aa92b14d0d99a8991856934a5ac32fcba0ad12b Cr-Commit-Position: refs/heads/master@{#403141}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 3

Patch Set 3 : for comment #8 #

Total comments: 2

Patch Set 4 : for comment #13 #

Total comments: 10

Patch Set 5 : for comment #16 #

Patch Set 6 : . #

Patch Set 7 : rebased #

Total comments: 2

Patch Set 8 : for comment #18 #

Patch Set 9 : rebased #

Patch Set 10 : Add dependency to wm::test_support from ash::unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -67 lines) Patch
M ash/BUILD.gn View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M ash/ash.gyp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/window_manager_unittest.cc View 1 2 3 4 5 6 5 chunks +18 lines, -23 lines 0 comments Download
M components/exo/pointer.h View 1 2 3 4 5 6 4 chunks +8 lines, -0 lines 0 comments Download
M components/exo/pointer.cc View 1 2 3 4 5 6 6 chunks +48 lines, -18 lines 0 comments Download
M ui/aura/client/cursor_client_observer.h View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M ui/wm/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M ui/wm/core/cursor_manager.cc View 3 4 1 chunk +4 lines, -1 line 0 comments Download
M ui/wm/core/cursor_manager_unittest.cc View 1 2 3 4 5 7 chunks +25 lines, -24 lines 0 comments Download
A ui/wm/test/testing_cursor_client_observer.h View 1 2 3 4 5 6 7 1 chunk +34 lines, -0 lines 0 comments Download
A ui/wm/test/testing_cursor_client_observer.cc View 1 2 3 4 5 1 chunk +32 lines, -0 lines 0 comments Download
M ui/wm/wm.gyp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
yoshiki
David, could you take a first look (mostly at exo part)?
4 years, 6 months ago (2016-06-15 17:18:12 UTC) #7
reveman
components/exo lgtm % nits https://codereview.chromium.org/2071553002/diff/20001/components/exo/pointer.cc File components/exo/pointer.cc (right): https://codereview.chromium.org/2071553002/diff/20001/components/exo/pointer.cc#newcode42 components/exo/pointer.cc:42: ash::Shell* ash_shell = ash::Shell::GetInstance(); nit: ...
4 years, 6 months ago (2016-06-15 17:48:30 UTC) #8
yoshiki
sky@, could you take a look at changes in /ui and /ash? reveman@, could you ...
4 years, 6 months ago (2016-06-20 04:52:48 UTC) #12
reveman
https://codereview.chromium.org/2071553002/diff/80001/components/exo/pointer.h File components/exo/pointer.h (right): https://codereview.chromium.org/2071553002/diff/80001/components/exo/pointer.h#newcode92 components/exo/pointer.h:92: bool use_large_cursor_; This member state looks unnecessary. Can we ...
4 years, 6 months ago (2016-06-20 05:01:34 UTC) #13
yoshiki
https://codereview.chromium.org/2071553002/diff/80001/components/exo/pointer.h File components/exo/pointer.h (right): https://codereview.chromium.org/2071553002/diff/80001/components/exo/pointer.h#newcode92 components/exo/pointer.h:92: bool use_large_cursor_; On 2016/06/20 05:01:34, reveman wrote: > This ...
4 years, 6 months ago (2016-06-20 07:12:35 UTC) #14
reveman
components/exo lgtm
4 years, 6 months ago (2016-06-20 14:01:33 UTC) #15
sky
https://codereview.chromium.org/2071553002/diff/100001/ash/wm/window_manager_unittest.cc File ash/wm/window_manager_unittest.cc (right): https://codereview.chromium.org/2071553002/diff/100001/ash/wm/window_manager_unittest.cc#newcode38 ash/wm/window_manager_unittest.cc:38: cursor_visibility_ = did_visibility_change_ = false; Shouldn't you reset cursor_set_ ...
4 years, 6 months ago (2016-06-20 15:27:51 UTC) #16
yoshiki
sky@, PTAL. Thanks https://codereview.chromium.org/2071553002/diff/100001/ash/wm/window_manager_unittest.cc File ash/wm/window_manager_unittest.cc (right): https://codereview.chromium.org/2071553002/diff/100001/ash/wm/window_manager_unittest.cc#newcode38 ash/wm/window_manager_unittest.cc:38: cursor_visibility_ = did_visibility_change_ = false; On ...
4 years, 5 months ago (2016-06-28 02:12:42 UTC) #17
sky
LGTM with the following https://codereview.chromium.org/2071553002/diff/160001/ui/wm/test/testing_cursor_client_observer.h File ui/wm/test/testing_cursor_client_observer.h (right): https://codereview.chromium.org/2071553002/diff/160001/ui/wm/test/testing_cursor_client_observer.h#newcode10 ui/wm/test/testing_cursor_client_observer.h:10: class TestingCursorClientObserver : public aura::client::CursorClientObserver ...
4 years, 5 months ago (2016-06-28 16:39:37 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2071553002/220001
4 years, 5 months ago (2016-06-30 11:05:08 UTC) #21
commit-bot: I haz the power
Committed patchset #10 (id:220001)
4 years, 5 months ago (2016-06-30 11:51:22 UTC) #23
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 11:53:12 UTC) #25
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/7aa92b14d0d99a8991856934a5ac32fcba0ad12b
Cr-Commit-Position: refs/heads/master@{#403141}

Powered by Google App Engine
This is Rietveld 408576698