Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 207153002: Remove repaint.js include from css3/filters tests (Closed)

Created:
6 years, 9 months ago by enne (OOO)
Modified:
6 years, 9 months ago
Reviewers:
jamesr, Stephen White
CC:
blink-reviews
Visibility:
Public.

Description

Remove repaint.js include from css3/filters tests BUG=345027 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170214

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -90 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/css3/filters/blur-filter-page-scroll.html View 3 chunks +9 lines, -4 lines 0 comments Download
M LayoutTests/css3/filters/blur-filter-page-scroll-parents.html View 2 chunks +8 lines, -3 lines 0 comments Download
M LayoutTests/css3/filters/blur-filter-page-scroll-self.html View 2 chunks +8 lines, -3 lines 0 comments Download
M LayoutTests/css3/filters/filter-change-repaint.html View 2 chunks +21 lines, -15 lines 0 comments Download
M LayoutTests/css3/filters/filter-change-repaint-composited.html View 4 chunks +23 lines, -17 lines 0 comments Download
M LayoutTests/css3/filters/filter-repaint.html View 1 chunk +9 lines, -4 lines 0 comments Download
M LayoutTests/css3/filters/filter-repaint-blur.html View 1 chunk +10 lines, -6 lines 0 comments Download
M LayoutTests/css3/filters/filter-repaint-child-layers.html View 1 chunk +10 lines, -4 lines 0 comments Download
M LayoutTests/css3/filters/filter-repaint-composited-fallback.html View 1 chunk +7 lines, -3 lines 0 comments Download
M LayoutTests/css3/filters/filter-repaint-composited-fallback-crash.html View 1 chunk +9 lines, -4 lines 0 comments Download
M LayoutTests/css3/filters/filter-repaint-sepia.html View 1 chunk +7 lines, -3 lines 0 comments Download
M LayoutTests/css3/filters/filter-repaint-shadow.html View 1 chunk +10 lines, -4 lines 0 comments Download
M LayoutTests/css3/filters/filter-repaint-shadow-clipped.html View 2 chunks +13 lines, -10 lines 0 comments Download
M LayoutTests/css3/filters/filter-repaint-shadow-rotated.html View 2 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
enne (OOO)
All of these tests appeared to be pixel-based / under-invalidation tests. Rather than making them ...
6 years, 9 months ago (2014-03-20 23:02:18 UTC) #1
Stephen White
This seems reasonable. Note that we inherited these tests from Adobe and Apple, and I ...
6 years, 9 months ago (2014-03-21 00:42:37 UTC) #2
enne (OOO)
Awesomely, commenting out the hasAncestorWithFilterOutsets block in scrollContentsFastPath and running css3/filters without this patch does ...
6 years, 9 months ago (2014-03-21 18:45:27 UTC) #3
enne (OOO)
senorblanco: ping?
6 years, 9 months ago (2014-03-27 19:24:04 UTC) #4
enne (OOO)
Er, +senorblanco.
6 years, 9 months ago (2014-03-27 19:24:28 UTC) #5
Stephen White
Ha! LGTM to land or remove at your discretion.
6 years, 9 months ago (2014-03-27 19:35:22 UTC) #6
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-27 19:37:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/207153002/1
6 years, 9 months ago (2014-03-27 19:37:42 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 19:47:55 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-27 19:47:55 UTC) #10
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-27 19:49:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/207153002/1
6 years, 9 months ago (2014-03-27 19:49:05 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 20:46:27 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 20:46:27 UTC) #14
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-27 20:54:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/207153002/1
6 years, 9 months ago (2014-03-27 20:54:50 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 22:32:46 UTC) #17
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-27 22:32:46 UTC) #18
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-27 22:40:38 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/207153002/1
6 years, 9 months ago (2014-03-27 22:41:18 UTC) #20
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 22:46:26 UTC) #21
Message was sent while issue was closed.
Change committed as 170214

Powered by Google App Engine
This is Rietveld 408576698