Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2071483002: [LayoutTests] add async callstack tests for V8 async functions (Closed)

Created:
4 years, 6 months ago by caitp (gmail)
Modified:
4 years, 6 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutTests] add async callstack tests for V8 async functions Based on https://codereview.chromium.org/2044223004 by littledan@chromium.org BUG=v8:4483, 621515 R=littledan@chromium.org, yangguo@chromium.org, dgozman@chromium.org, pfeldman@chromium.org Committed: https://crrev.com/3daa588ce613845e298cbd667fa6f5787f95d574 Cr-Commit-Position: refs/heads/master@{#400718}

Patch Set 1 #

Patch Set 2 : [LayoutTests] add async callstack tests for V8 async functions #

Messages

Total messages: 28 (13 generated)
caitp (gmail)
Hi, PTAL --- Obviously, the results are a bit weird at the moment. I think ...
4 years, 6 months ago (2016-06-15 14:30:46 UTC) #2
Dan Ehrenberg
lgtm The stack traces here are sort of morally similar to what Promise debugging gives ...
4 years, 6 months ago (2016-06-15 15:52:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071483002/1
4 years, 6 months ago (2016-06-16 19:50:37 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-16 19:50:40 UTC) #7
caitp (gmail)
+aklein for rubber stamp (assuming you're still a Blink committer :x)
4 years, 6 months ago (2016-06-17 15:32:23 UTC) #9
dgozman
rs lgtm You have to add separate expectations to virtual/ since they differ with flag, ...
4 years, 6 months ago (2016-06-18 05:43:38 UTC) #10
caitp (gmail)
On 2016/06/18 05:43:38, dgozman_slow wrote: > rs lgtm > > You have to add separate ...
4 years, 6 months ago (2016-06-18 14:36:42 UTC) #11
Yang
On 2016/06/18 14:36:42, caitp wrote: > On 2016/06/18 05:43:38, dgozman_slow wrote: > > rs lgtm ...
4 years, 6 months ago (2016-06-20 06:50:08 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071483002/1
4 years, 6 months ago (2016-06-20 12:44:19 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/246712)
4 years, 6 months ago (2016-06-20 14:06:45 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071483002/20001
4 years, 6 months ago (2016-06-20 14:21:55 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-20 17:41:53 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071483002/20001
4 years, 6 months ago (2016-06-20 17:46:53 UTC) #24
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-20 17:52:24 UTC) #26
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 17:58:34 UTC) #28
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3daa588ce613845e298cbd667fa6f5787f95d574
Cr-Commit-Position: refs/heads/master@{#400718}

Powered by Google App Engine
This is Rietveld 408576698