Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2071443003: Introduce different repo types (git and gitiles) (Closed)

Created:
4 years, 6 months ago by Paweł Hajdan Jr.
Modified:
4 years, 6 months ago
Reviewers:
iannucci, estaab, martiniss
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://github.com/luci/recipes-py.git@master
Target Ref:
refs/heads/master
Project:
recipes-py
Visibility:
Public.

Description

Introduce different repo types (git and gitiles) NOPRESUBMIT=true BUG=chromium:459840 Committed: https://github.com/luci/recipes-py/commit/d6f0e607c1bca05178f248b9f06619749a8c42d8

Patch Set 1 #

Patch Set 2 : 80cols #

Total comments: 2

Patch Set 3 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -122 lines) Patch
M recipe_engine/fetch.py View 1 2 1 chunk +92 lines, -84 lines 0 comments Download
M recipe_engine/package.proto View 2 chunks +13 lines, -2 lines 0 comments Download
M recipe_engine/package.py View 1 2 4 chunks +24 lines, -12 lines 0 comments Download
M recipe_engine/package_pb2.py View 3 chunks +36 lines, -5 lines 0 comments Download
M recipe_engine/remote_run.py View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M recipe_engine/unittests/fetch_test.py View 1 2 7 chunks +16 lines, -8 lines 0 comments Download
M unittests/package_test.py View 3 chunks +3 lines, -6 lines 0 comments Download
M unittests/repo_test_util.py View 1 2 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 23 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071443003/1
4 years, 6 months ago (2016-06-15 13:47:56 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Recipes-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Recipes-py%20Presubmit/builds/280)
4 years, 6 months ago (2016-06-15 13:51:47 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071443003/20001
4 years, 6 months ago (2016-06-15 13:57:56 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Recipes-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Recipes-py%20Presubmit/builds/283)
4 years, 6 months ago (2016-06-15 14:02:13 UTC) #8
Paweł Hajdan Jr.
Please review. Presubmit is complaining about a generated file.
4 years, 6 months ago (2016-06-15 14:19:13 UTC) #10
martiniss
lgtm https://codereview.chromium.org/2071443003/diff/20001/recipe_engine/fetch.py File recipe_engine/fetch.py (right): https://codereview.chromium.org/2071443003/diff/20001/recipe_engine/fetch.py#newcode52 recipe_engine/fetch.py:52: class GitBackend(object): Just backend? Instead of git backend.
4 years, 6 months ago (2016-06-15 21:45:19 UTC) #11
estaab
lgtm
4 years, 6 months ago (2016-06-15 22:42:30 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071443003/40001
4 years, 6 months ago (2016-06-17 09:24:58 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Recipes-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Recipes-py%20Presubmit/builds/287)
4 years, 6 months ago (2016-06-17 09:28:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071443003/40001
4 years, 6 months ago (2016-06-17 09:30:08 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://github.com/luci/recipes-py/commit/d6f0e607c1bca05178f248b9f06619749a8c42d8
4 years, 6 months ago (2016-06-17 09:30:20 UTC) #22
Paweł Hajdan Jr.
4 years, 6 months ago (2016-06-17 12:30:25 UTC) #23
Message was sent while issue was closed. 
https://codereview.chromium.org/2071443003/diff/20001/recipe_engine/fetch.py
File recipe_engine/fetch.py (right):

https://codereview.chromium.org/2071443003/diff/20001/recipe_engine/fetch.py#...
recipe_engine/fetch.py:52: class GitBackend(object):
On 2016/06/15 at 21:45:19, martiniss wrote:
> Just backend? Instead of git backend.

Done.

Powered by Google App Engine
This is Rietveld 408576698