content/renderer/shared_worker/embedded_shared_worker_stub.cc - Issue 2071433003: Reland: service worker: Don't control a subframe of an insecure context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/shared_worker/embedded_shared_worker_stub.cc

Issue 2071433003: Reland: service worker: Don't control a subframe of an insecure context (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revised Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/service_worker/service_worker_context_client.cc ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/insecure-parent-frame.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/shared_worker/embedded_shared_worker_stub.cc

diff --git a/content/renderer/shared_worker/embedded_shared_worker_stub.cc b/content/renderer/shared_worker/embedded_shared_worker_stub.cc

index ba2707c905539ecc4f30c0203b9def9ff8eb99c9..4b7509754fc387908a83a7916bdfab0e13557248 100644

--- a/content/renderer/shared_worker/embedded_shared_worker_stub.cc

+++ b/content/renderer/shared_worker/embedded_shared_worker_stub.cc

@@ -242,7 +242,8 @@ EmbeddedSharedWorkerStub::createServiceWorkerNetworkProvider(

// we can observe its requests.

std::unique_ptr<ServiceWorkerNetworkProvider> provider(

new ServiceWorkerNetworkProvider(

- route_id_, SERVICE_WORKER_PROVIDER_FOR_SHARED_WORKER));

+ route_id_, SERVICE_WORKER_PROVIDER_FOR_SHARED_WORKER,

+ true /* is_parent_frame_secure */));

// The provider is kept around for the lifetime of the DataSource

// and ownership is transferred to the DataSource.