content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc - Issue 2071433003: Reland: service worker: Don't control a subframe of an insecure context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

Issue 2071433003: Reland: service worker: Don't control a subframe of an insecure context (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revised Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_version_unittest.cc ('k') | content/child/service_worker/service_worker_network_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc b/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

index cc8de0f4a815785eb78fbc2d962077670b032f88..b63291fd3780705d48e39f9c36bd47e0e5b1ff8d 100644

--- a/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

@@ -280,9 +280,11 @@ class ServiceWorkerWriteToCacheJobTest : public testing::Test {

int provider_id,

const scoped_refptr<ServiceWorkerVersion>& version) {

std::unique_ptr<ServiceWorkerProviderHost> host(

- new ServiceWorkerProviderHost(process_id, MSG_ROUTING_NONE, provider_id,

- SERVICE_WORKER_PROVIDER_FOR_WORKER,

- context()->AsWeakPtr(), nullptr));

+ new ServiceWorkerProviderHost(

+ process_id, MSG_ROUTING_NONE, provider_id,

+ SERVICE_WORKER_PROVIDER_FOR_WORKER,

+ ServiceWorkerProviderHost::FrameSecurityLevel::SECURE,

+ context()->AsWeakPtr(), nullptr));

base::WeakPtr<ServiceWorkerProviderHost> provider_host = host->AsWeakPtr();

context()->AddProviderHost(std::move(host));

provider_host->running_hosted_version_ = version;