Filter all events in SystemModalContainerEventHandler

Filter all events in SystemModalContainerEventHandler

BUG=620406
TEST=covered by unit test, manual

Committed: https://crrev.com/4a69b3b040908d2d0414af656c82c77705929bfb
Cr-Commit-Position: refs/heads/master@{#400750}

[oshima, 2016-06-18 07:34:17]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-18 07:34:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2071423003/1

[commit-bot: I haz the power, 2016-06-18 08:29:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-18 08:29:28]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-06-20 14:14:00]

Patchset #2 (id:20001) has been deleted

[oshima, 2016-06-20 14:14:10]

Patchset #1 (id:1) has been deleted

[oshima, 2016-06-20 14:14:32]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-20 14:14:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2071423003/40001

[commit-bot: I haz the power, 2016-06-20 14:53:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 14:53:06]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-06-20 16:06:43]

Description was changed from

==========
Filter all events in SystemModalContainerEventHandler

BUG=620406
==========

to

==========
Filter all events in SystemModalContainerEventHandler

BUG=620406
TEST=covered by unit test, manual
==========

[oshima, 2016-06-20 16:06:43]

oshima@chromium.org changed reviewers:
+ jamescook@chromium.org

[James Cook, 2016-06-20 17:33:20]

LGTM

https://codereview.chromium.org/2071423003/diff/40001/ash/wm/system_modal_con...
File ash/wm/system_modal_container_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2071423003/diff/40001/ash/wm/system_modal_con...
ash/wm/system_modal_container_layout_manager_unittest.cc:711: EXPECT_EQ(2,
mouse_event_count_);
nit: Can you add a Reset() method that puts all the counts to zero, then check
against 0 for all of these?

That would be easier to read here, and would make the counts below 2,3,4,10
which would match above.

[oshima, 2016-06-20 18:23:54]

https://codereview.chromium.org/2071423003/diff/40001/ash/wm/system_modal_con...
File ash/wm/system_modal_container_layout_manager_unittest.cc (right):

https://codereview.chromium.org/2071423003/diff/40001/ash/wm/system_modal_con...
ash/wm/system_modal_container_layout_manager_unittest.cc:711: EXPECT_EQ(2,
mouse_event_count_);
On 2016/06/20 17:33:20, James Cook wrote:
> nit: Can you add a Reset() method that puts all the counts to zero, then check
> against 0 for all of these?
> 
> That would be easier to read here, and would make the counts below 2,3,4,10
> which would match above.

Done.

[oshima, 2016-06-20 18:23:59]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-06-20 18:23:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2071423003/#ps60001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-06-20 18:24:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2071423003/60001

[commit-bot: I haz the power, 2016-06-20 19:33:05]

Description was changed from

==========
Filter all events in SystemModalContainerEventHandler

BUG=620406
TEST=covered by unit test, manual
==========

to

==========
Filter all events in SystemModalContainerEventHandler

BUG=620406
TEST=covered by unit test, manual
==========

[commit-bot: I haz the power, 2016-06-20 19:33:06]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-06-20 19:36:09]

Description was changed from

==========
Filter all events in SystemModalContainerEventHandler

BUG=620406
TEST=covered by unit test, manual
==========

to

==========
Filter all events in SystemModalContainerEventHandler

BUG=620406
TEST=covered by unit test, manual

Committed: https://crrev.com/4a69b3b040908d2d0414af656c82c77705929bfb
Cr-Commit-Position: refs/heads/master@{#400750}
==========

[commit-bot: I haz the power, 2016-06-20 19:36:10]

Patchset 2 (id:??) landed as
https://crrev.com/4a69b3b040908d2d0414af656c82c77705929bfb
Cr-Commit-Position: refs/heads/master@{#400750}