Abandoned. Gerrit git cl upload: warn users assuming --no-squash by default.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld and Gerrit."""
 
 from __future__ import print_function
@@ skipping 752 matching lines @@
 
   def GetIsGerrit(self):
     """Return true if this repo is assosiated with gerrit code review system."""
     if self.is_gerrit is None:
       self.is_gerrit = self._GetConfig('gerrit.host', error_ok=True)
     return self.is_gerrit
 
   def GetSquashGerritUploads(self):
     """Return true if uploads to Gerrit should be squashed by default."""
     if self.squash_gerrit_uploads is None:
-      self.squash_gerrit_uploads = (
-          RunGit(['config', '--bool', 'gerrit.squash-uploads'],
-                 error_ok=True).strip() == 'true')
+      self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
+      if self.squash_gerrit_uploads is None:
+        # TODO(tandrii): switch this from ==true to not ==false.
+        self.squash_gerrit_uploads = (
+            RunGit(['config', '--bool', 'gerrit.squash-uploads'],
+                   error_ok=True).strip() == 'true')
     return self.squash_gerrit_uploads
 
+  def GetSquashGerritUploadsOverride(self):
+    """Return True or False if codereview.settings should be overridden.
+
+    Returns None if no override has been defined.
+    """
+    # See also http://crbug.com/611892#c23
+    result = RunGit(['config', '--bool', 'gerrit.override-squash-uploads'],
+                    error_ok=True).strip()
+    if result == 'true':
+      return True
+    if result == 'false':
+      return False
+    return None
+
   def GetGerritSkipEnsureAuthenticated(self):
     """Return True if EnsureAuthenticated should not be done for Gerrit
     uploads."""
     if self.gerrit_skip_ensure_authenticated is None:
       self.gerrit_skip_ensure_authenticated = (
           RunGit(['config', '--bool', 'gerrit.skip-ensure-authenticated'],
                  error_ok=True).strip() == 'true')
     return self.gerrit_skip_ensure_authenticated
 
   def GetGitEditor(self):
@@ skipping 1543 matching lines @@
       if reply.lower().startswith('y'):
         gclient_utils.rm_file_or_tree(hook)
         print('Gerrit commit-msg hook removed.')
       else:
         print('OK, will keep Gerrit commit-msg hook in place.')
 
   def CMDUploadChange(self, options, args, change):
     """Upload the current branch to Gerrit."""
     if options.squash and options.no_squash:
       DieWithError('Can only use one of --squash or --no-squash')
-    options.squash = ((settings.GetSquashGerritUploads() or options.squash) and
-                      not options.no_squash)
+
+    if not options.squash and not options.no_squash:
+      options.squash = settings.GetSquashGerritUploads()
+      # TODO(tandrii): remove this by June 20.
+      if (settings.GetSquashGerritUploadsOverride() is None and
+          not options.squash):
+          print('\n\nYou are using git cl upload in --no-squash mode '
+                'by default.\n'
+                'Chrome infrastructure wants to make --squash the default.\n'
+                'To ensure that --no-squash is still the default for YOU do:\n'
+                '   git config --bool gerrit.override-squash-uploads false\n'
+                'See https://goo.gl/dnK2gV (use chromium.org account!) and '
+                'let us know what you think. Thanks!\n'
+                'BUG: http://crbug.com/611892\n\n')
+    elif options.no_squash:
+      options.squash = False
 
     # We assume the remote called "origin" is the one we want.
     # It is probably not worthwhile to support different workflows.
     gerrit_remote = 'origin'
 
     remote, remote_branch = self.GetRemoteBranch()
     branch = GetTargetRef(remote, remote_branch, options.target_branch,
                           pending_prefix='')
 
     if options.squash:
@@ skipping 2667 matching lines @@
 if __name__ == '__main__':
   # These affect sys.stdout so do it outside of main() to simplify mocks in
   # unit testing.
   fix_encoding.fix_encoding()
   setup_color.init()
   try:
     sys.exit(main(sys.argv[1:]))
   except KeyboardInterrupt:
     sys.stderr.write('interrupted\n')
     sys.exit(1)